kenhuuu commented on code in PR #3078: URL: https://github.com/apache/tinkerpop/pull/3078#discussion_r2024050245
########## gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/util/SSLStoreFilesModificationWatcher.java: ########## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.server.util; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.nio.file.attribute.BasicFileAttributes; +import java.time.ZoneOffset; +import java.time.ZonedDateTime; + +/** + * FileWatcher monitoring changes to SSL keyStore/trustStore files. + * If a keyStore/trustStore file is set to null, it will be ignored. + * If a keyStore/trustStore file is deleted, it will be considered not modified. + */ +public class SSLStoreFilesModificationWatcher implements Runnable { + + private static final Logger logger = LoggerFactory.getLogger(SSLStoreFilesModificationWatcher.class); + + private final Path keyStore; + private final Path trustStore; + private final Runnable onModificationRunnable; + + private ZonedDateTime lastModifiedTimeKeyStore = null; + private ZonedDateTime lastModifiedTimeTrustStore = null; + + /** + * Create a FileWatcher on keyStore/trustStore + * + * @param keyStore path to the keyStore file or null to ignore + * @param trustStore path to the trustStore file or null to ignore + * @param onModificationRunnable function to run when a modification to the keyStore or trustStore is detected + */ + public SSLStoreFilesModificationWatcher(String keyStore, String trustStore, Runnable onModificationRunnable) { Review Comment: ```suggestion public SSLStoreFilesModificationWatcher(final String keyStore, final String trustStore, final Runnable onModificationRunnable) { ``` Nit: missing finals in several parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
