Cole-Greer commented on code in PR #3090:
URL: https://github.com/apache/tinkerpop/pull/3090#discussion_r2032003458


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/DateAddStep.java:
##########


Review Comment:
   I agree that the available precision here is odd, although this is really 
out of scope for this PR and should be taken as a separate discussion. I think 
there should be come consideration of taking a Duration as input instead of an 
int and DT enum, although some consideration is needed around how to make 
Duration's constructable in gremlin-lang.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to