andreachild commented on code in PR #3099:
URL: https://github.com/apache/tinkerpop/pull/3099#discussion_r2058910838
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/traversal-strategy.js:
##########
@@ -239,6 +276,16 @@ class PathRetractionStrategy extends TraversalStrategy {
}
}
+class ProductiveByStrategy extends TraversalStrategy {
+ /**
+ * @param {Object} [options]
+ * @param {Array<String>} [options.productiveKeys] set of keys that will
always be productive
+ */
+ constructor(options) {
+
super('org.apache.tinkerpop.gremlin.process.traversal.strategy.optimization.ProductiveByStrategy',
options);
Review Comment:
I'm curious why in this case the full `options` are passed through to the
super constructor but for other strategies like `SeedStrategy` only specific
options are passed through? Especially since the js doc for this function
specifically mentions `options.productiveKeys`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
