spmallette commented on code in PR #3118:
URL: https://github.com/apache/tinkerpop/pull/3118#discussion_r2135840793
##########
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/SelectOneStepTest.java:
##########
@@ -61,4 +64,57 @@ public void shouldRequirePathsAccordingly() {
assertEquals(traversalPath[0], ((Traversal.Admin<?, ?>)
traversalPath[1]).getTraverserRequirements().contains(TraverserRequirement.LABELED_PATH));
}
}
+
+ @Test
+ public void testPopInstruction() {
Review Comment:
nit: note that TinkerPop tests prefer "should" prefix over "test" for test
name, like "shouldObtainPopInstructions" would be a good name here. please take
a look at other tests in the PR and make changes accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
