spmallette commented on code in PR #3233:
URL: https://github.com/apache/tinkerpop/pull/3233#discussion_r2421132364
##########
docs/src/reference/the-traversal.asciidoc:
##########
@@ -635,31 +631,23 @@ g.V().out('knows').aggregate('x').by('age').cap('x') <1>
<1> The "age" property is not <<by-step,productive>> for all vertices and
therefore those values are not included in the aggregation.
-For `local` scope the aggregation will occur in a
link:http://en.wikipedia.org/wiki/Lazy_evaluation[lazy] fashion.
-
-NOTE: Prior to 3.4.3, `local` aggregation (i.e. lazy) evaluation was handled
by `store()`-step.
+Aggregation can be controlled to occur in a
link:http://en.wikipedia.org/wiki/Lazy_evaluation[lazy] fashion by using
+the step inside `local()`.
[gremlin-groovy,modern]
----
-g.V().aggregate(global, 'x').limit(1).cap('x')
-g.V().aggregate(local, 'x').limit(1).cap('x')
-g.withoutStrategies(EarlyLimitStrategy).V().aggregate(local,'x').limit(1).cap('x')
+g.V().aggregate('x').limit(1).cap('x')
+g.V().local(aggregate('x')).limit(1).cap('x')
----
-It is important to note that `EarlyLimitStrategy` introduced in 3.3.5 alters
the behavior of `aggregate(local)`.
Review Comment:
hmm, that's a nice side-effect of removal. something to call out in Upgrade
Docs to help flesh those out more?
Just a check but have you confirmed that all these examples do in fact
return the same results as the ones with `aggregate(local)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
