Cole-Greer commented on code in PR #3273:
URL: https://github.com/apache/tinkerpop/pull/3273#discussion_r2501439701
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/SampleGlobalStep.java:
##########
@@ -135,7 +137,39 @@ public void barrierConsumer(final TraverserSet<S>
traverserSet) {
traverserSet.addAll(sampledSet);
}
+ @Override
+ public MemoryComputeKey<TraverserSet<S>> getMemoryComputeKey() {
+ return MemoryComputeKey.of(this.getId(), new SampleBiOperator<>(),
false, true);
Review Comment:
Nit: Could save on some object initialization overhead here by reusing a
single SampleBiOperator object, although I highly doubt there would be any
significance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
