kenhuuu commented on code in PR #3309:
URL: https://github.com/apache/tinkerpop/pull/3309#discussion_r2875177364
##########
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary/Types/TraversalSerializer.cs:
##########
@@ -37,15 +37,15 @@ public class TraversalSerializer :
SimpleTypeSerializer<ITraversal>
/// <summary>
/// Initializes a new instance of the <see
cref="TraversalSerializer" /> class.
/// </summary>
- public TraversalSerializer() : base(DataType.Bytecode)
+ public TraversalSerializer() : base(DataType.FromTypeCode(0x15))
{
}
/// <inheritdoc />
- protected override async Task WriteValueAsync(ITraversal value, Stream
stream, GraphBinaryWriter writer,
+ protected override Task WriteValueAsync(ITraversal value, Stream
stream, GraphBinaryWriter writer,
CancellationToken cancellationToken = default)
{
- await writer.WriteNonNullableValueAsync(value.Bytecode, stream,
cancellationToken).ConfigureAwait(false);
+ throw new NotSupportedException("Traversal serialization via
GraphBinary is no longer supported. Use GremlinLang instead.");
Review Comment:
Why not just remove this from the interface altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
