Cole-Greer commented on code in PR #3336:
URL: https://github.com/apache/tinkerpop/pull/3336#discussion_r2972180020
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/package.json:
##########
@@ -20,29 +20,42 @@
"type": "module",
"main": "./build/cjs/index.cjs",
"exports": {
- "import": "./build/esm/index.js",
- "require": "./build/cjs/index.cjs"
+ ".": {
+ "import": "./build/esm/index.js",
+ "require": "./build/cjs/index.cjs"
+ },
+ "./language": {
+ "import": "./build/esm/language/index.js",
+ "types": "./build/esm/language/index.d.ts"
+ }
+ },
+ "typesVersions": {
+ "*": {
+ "language": ["./build/esm/language/index.d.ts"]
+ }
},
"files": [
"build"
],
"dependencies": {
+ "antlr4ng": "~3.0.16",
"buffer": "^6.0.3",
"eventemitter3": "^5.0.1",
"readable-stream": "^4.5.2",
"uuid": "^9.0.1"
},
"devDependencies": {
"@cucumber/cucumber": "~12.7.0",
- "@knighted/duel": "^1.0.7",
+ "@eslint/js": "^9.16.0",
+ "@knighted/duel": "^4.0.2",
Review Comment:
It looks like `"@knighted/duel"` required node >=22.21.1, which is breaking
the node 20 build. I'm not sure if this can reasonably be dropped to an older
version which maintain compatibility with node 20, or if we want to go ahead
and drop our support for Node 20 in TinkerPop 4.
Node 20 is about to hit end of life, and we already support 22 and 24, so I
don't think there's much harm in us moving on. https://endoflife.date/nodejs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
