spmallette opened a new pull request, #3341:
URL: https://github.com/apache/tinkerpop/pull/3341
Modernized our Javascript setup which should make it easier for contributors
and agents to work on:
- New gremlin-js/ Maven parent module — gremlin-javascript, gremlin-mcp,
and gremlint are now co-located under gremlin-js/ with a single parent pom.xml.
The root pom.xml goes from three JS module entries down to one (gremlin-js),
and the frontend-maven-plugin that drives npm ci lives exclusively in the
parent (not duplicated across children).
- Single npm workspace with one consolidated lockfile — All three JS
packages are now declared as npm workspace members. The three per-package
package-lock.json files (~24k lines) are replaced by a single workspace-root
package-lock.json (~16k lines). This also unlocks local workspace resolution,
allowing gremlin-mcp to depend on gremlin via a real semver range ("gremlin":
"4.0.0-alpha1") instead of a file: path — during development npm resolves it
from the local sibling; after publish it resolves from the registry.
- Docker container and CI path surgery — The container also now runs as
the host user (uid:gid) to prevent root-owned files from leaking into the
bind-mounted workspace.
This is a big PR but it's mostly file moves. Github diff seems to do a
pretty good job of hiding away those moves. Might help to pull this branch
locally to get a feel for what the changes really look like.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
