Cole-Greer commented on code in PR #3485:
URL: https://github.com/apache/tinkerpop/pull/3485#discussion_r3531808683
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/DotNetTranslateVisitor.java:
##########
@@ -1255,11 +1209,19 @@ public Void visitDurationLiteral(final
GremlinParser.DurationLiteralContext ctx)
@Override
public Void visitPdtLiteral(final GremlinParser.PdtLiteralContext ctx) {
- sb.append("new ProviderDefinedType(");
- sb.append(ctx.stringLiteral().getText());
- sb.append(", ");
- visitGenericMapLiteral(ctx.genericMapLiteral());
- sb.append(")");
+ if (ctx.genericMapLiteral() != null) {
+ sb.append("new ProviderDefinedType(");
+ sb.append(ctx.stringLiteral(0).getText());
+ sb.append(", ");
+ visitGenericMapLiteral(ctx.genericMapLiteral());
+ sb.append(")");
+ } else {
+ sb.append("new PrimitiveProviderDefinedType(");
Review Comment:
I'll rename these to `CompositePDT` and `PrimitivePDT` (or equivalents) in
all GLVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]