This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/master by this push:
     new ceb34ad148 Fix sample Gremlin Server configs that named removed 
serializers
ceb34ad148 is described below

commit ceb34ad1484bdb754002b90f5ca0c4e5297418b9
Author: Stephen Mallette <[email protected]>
AuthorDate: Mon Oct 12 12:52:28 2026 -0400

    Fix sample Gremlin Server configs that named removed serializers
    
    Seven configs in gremlin-server/conf still listed the V1-V3 serializers and
    would not start. GremlinServerConfigIntegrateTest now starts each config
    with its own serializers so it catches this.
    
    Assisted-by: Claude Code:claude-opus-5-5
---
 gremlin-server/conf/gremlin-server-classic.yaml                   | 6 +++---
 gremlin-server/conf/gremlin-server-modern-readonly.yaml           | 6 +++---
 gremlin-server/conf/gremlin-server-rest-modern.yaml               | 8 ++++----
 gremlin-server/conf/gremlin-server-rest-secure.yaml               | 2 +-
 gremlin-server/conf/gremlin-server-secure.yaml                    | 6 +++---
 gremlin-server/conf/gremlin-server-spark.yaml                     | 6 +++---
 gremlin-server/conf/gremlin-server-transaction.yaml               | 6 +++---
 .../gremlin/server/GremlinServerConfigIntegrateTest.java          | 2 --
 8 files changed, 20 insertions(+), 22 deletions(-)

diff --git a/gremlin-server/conf/gremlin-server-classic.yaml 
b/gremlin-server/conf/gremlin-server-classic.yaml
index a97016ddcc..04abff40b1 100644
--- a/gremlin-server/conf/gremlin-server-classic.yaml
+++ b/gremlin-server/conf/gremlin-server-classic.yaml
@@ -23,9 +23,9 @@ graphs: {
 lifecycleHooks:
   - { className: 
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config: 
{graph: graph, dataset: classic}}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   slf4jReporter: {enabled: true, intervalMillis: 180000}}
 strictTransactionManagement: false
diff --git a/gremlin-server/conf/gremlin-server-modern-readonly.yaml 
b/gremlin-server/conf/gremlin-server-modern-readonly.yaml
index 050cd502ea..7b0e51e0ff 100644
--- a/gremlin-server/conf/gremlin-server-modern-readonly.yaml
+++ b/gremlin-server/conf/gremlin-server-modern-readonly.yaml
@@ -25,9 +25,9 @@ graphs: {
 lifecycleHooks:
   - { className: 
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config: 
{graph: graph, dataset: modern}}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   slf4jReporter: {enabled: true, intervalMillis: 180000}}
 strictTransactionManagement: false
diff --git a/gremlin-server/conf/gremlin-server-rest-modern.yaml 
b/gremlin-server/conf/gremlin-server-rest-modern.yaml
index 0ba33f001e..f9231f4789 100644
--- a/gremlin-server/conf/gremlin-server-rest-modern.yaml
+++ b/gremlin-server/conf/gremlin-server-rest-modern.yaml
@@ -24,10 +24,10 @@ graphs: {
 lifecycleHooks:
   - { className: 
org.apache.tinkerpop.gremlin.server.util.TinkerFactoryDataLoader, config: 
{graph: graph, dataset: modern}}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONUntypedMessageSerializerV3, 
config: { ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}     
# application/vnd.gremlin-v3.0+json;types=false
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/vnd.gremlin-v3.0+json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONUntypedMessageSerializerV4, 
config: { ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}     
# application/vnd.gremlin-v3.0+json;types=false
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/vnd.gremlin-v3.0+json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   slf4jReporter: {enabled: true, intervalMillis: 180000}}
 strictTransactionManagement: false
diff --git a/gremlin-server/conf/gremlin-server-rest-secure.yaml 
b/gremlin-server/conf/gremlin-server-rest-secure.yaml
index 4a04569203..038c5b7a40 100644
--- a/gremlin-server/conf/gremlin-server-rest-secure.yaml
+++ b/gremlin-server/conf/gremlin-server-rest-secure.yaml
@@ -30,7 +30,7 @@ channelizer: 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizer
 graphs: {
   graph: conf/tinkergraph-empty.properties}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
 metrics: {
   consoleReporter: {enabled: true, intervalMillis: 180000},
   csvReporter: {enabled: true, intervalMillis: 180000, fileName: 
/tmp/gremlin-server-metrics.csv},
diff --git a/gremlin-server/conf/gremlin-server-secure.yaml 
b/gremlin-server/conf/gremlin-server-secure.yaml
index 4d971714b7..1e29033532 100644
--- a/gremlin-server/conf/gremlin-server-secure.yaml
+++ b/gremlin-server/conf/gremlin-server-secure.yaml
@@ -30,9 +30,9 @@ channelizer: 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizer
 graphs: {
   graph: conf/tinkergraph-empty.properties}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   consoleReporter: {enabled: true, intervalMillis: 180000},
   csvReporter: {enabled: true, intervalMillis: 180000, fileName: 
/tmp/gremlin-server-metrics.csv},
diff --git a/gremlin-server/conf/gremlin-server-spark.yaml 
b/gremlin-server/conf/gremlin-server-spark.yaml
index 1bc07bb3fa..a6803398c7 100644
--- a/gremlin-server/conf/gremlin-server-spark.yaml
+++ b/gremlin-server/conf/gremlin-server-spark.yaml
@@ -52,9 +52,9 @@ scriptEngines: {
                org.apache.tinkerpop.gremlin.jsr223.ImportGremlinPlugin: 
{classImports: [java.lang.Math], methodImports: [java.lang.Math#*]},
                org.apache.tinkerpop.gremlin.jsr223.ScriptFileGremlinPlugin: 
{files: [scripts/spark.groovy]}}}}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   consoleReporter: {enabled: true, intervalMillis: 180000},
   csvReporter: {enabled: true, intervalMillis: 180000, fileName: 
/tmp/gremlin-server-metrics.csv},
diff --git a/gremlin-server/conf/gremlin-server-transaction.yaml 
b/gremlin-server/conf/gremlin-server-transaction.yaml
index b8fc53808b..ba5eab861b 100644
--- a/gremlin-server/conf/gremlin-server-transaction.yaml
+++ b/gremlin-server/conf/gremlin-server-transaction.yaml
@@ -22,9 +22,9 @@ channelizer: 
org.apache.tinkerpop.gremlin.server.channel.HttpChannelizer
 graphs: {
   graph: conf/tinkerstoragegraph-empty.properties}
 serializers:
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV3, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
-  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphSONMessageSerializerV4, config: { 
ioRegistries: 
[org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerIoRegistryV3] }}      
      # application/json
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4 }          
                                                                                
                 # application/vnd.graphbinary-v1.0
+  - { className: 
org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV4, config: { 
serializeResultToString: true }}                                                
                 # application/vnd.graphbinary-v1.0-stringd
 metrics: {
   consoleReporter: {enabled: true, intervalMillis: 180000},
   csvReporter: {enabled: true, intervalMillis: 180000, fileName: 
/tmp/gremlin-server-metrics.csv},
diff --git 
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerConfigIntegrateTest.java
 
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerConfigIntegrateTest.java
index 7c4242c11e..1aadc1557b 100644
--- 
a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerConfigIntegrateTest.java
+++ 
b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerConfigIntegrateTest.java
@@ -33,7 +33,6 @@ import java.io.File;
 import java.io.FileInputStream;
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.List;
 
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -70,7 +69,6 @@ public class GremlinServerConfigIntegrateTest {
         final File confDir = new 
File(TestSupport.getRootOfBuildDirectory(GremlinServerConfigIntegrateTest.class),
 "../conf");
         final Settings settings = Settings.read(new FileInputStream(new 
File(confDir, configName)));
 
-        settings.serializers = Collections.emptyList();
         ServerTestHelper.rewritePathsInGremlinServerSettings(settings);
 
         final GremlinServer server = new GremlinServer(settings);

Reply via email to