[
https://issues.apache.org/jira/browse/TOMEE-4355?focusedWorklogId=925434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925434
]
ASF GitHub Bot logged work on TOMEE-4355:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/24 12:16
Start Date: 11/Jul/24 12:16
Worklog Time Spent: 10m
Work Description: rmannibucau commented on code in PR #1278:
URL: https://github.com/apache/tomee/pull/1278#discussion_r1673912741
##########
tomee/tomee-mojarra/src/main/java/org/apache/tomee/mojarra/TomEEMojarraService.java:
##########
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomee.mojarra;
+
+import com.sun.faces.cdi.CdiExtension;
+import org.apache.openejb.cdi.OptimizedLoaderService;
+import org.apache.openejb.config.event.BeforeDeploymentEvent;
+import org.apache.openejb.loader.SystemInstance;
+import org.apache.openejb.observer.Observes;
+import org.apache.openejb.spi.Service;
+import org.apache.tomee.mojarra.owb.OwbCompatibleCdiExtension;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Properties;
+
+public class TomEEMojarraService implements Service {
Review Comment:
I'm not strictly opposed to that but if you set a threadlocal you should
reset it
my 2 cts: drop the service, drop the threadlocal and just hardcode the
extension replacement in the loader, this is a global replacement not per
instance
Issue Time Tracking
-------------------
Worklog Id: (was: 925434)
Time Spent: 1h (was: 50m)
> mojarra faces.js is truncated
> -----------------------------
>
> Key: TOMEE-4355
> URL: https://issues.apache.org/jira/browse/TOMEE-4355
> Project: TomEE
> Issue Type: Bug
> Components: TomEE Core Server
> Affects Versions: 10.0.0-M1
> Environment: macOS, java 17
> Reporter: Jens Heitmann
> Priority: Major
> Attachments: image-2024-07-02-14-09-44-214.png, test.war
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> I've just test the 10. M1 release. Several things are working, but the
> faces.js is truncated, which results in some Ajax errors. It is working with
> wildfly and the old java version too.
> I've created a small project showing this bug. Maybe it's a configuration
> fault, but I think it may be a good to have a view on it. Because it is
> working in other environments and a quite simple project, and if it is really
> a bug, it might be very important.
> For testing
> Deploy.the war and open the browsers development console. Check the faces.js
> in the Sources view. Scroll to the bottom and you will see that it is
> truncated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
