[
https://issues.apache.org/jira/browse/TOMEE-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916765#comment-17916765
]
Niall Pemberton commented on TOMEE-4448:
----------------------------------------
Hi [~rzo1]
It looks to me like _*tomee-site-pub*_ is out of sync with
_*tomee-site-generator*_ which is why I raised the PR to (mainly) delete files
from _*tomee-site-pub*_ which didn't seem to have an equivalent _*adoc*_ file
in {_}*tomee-site-generator*{_}.
So I don't know what actions I can raise a PR against _*tomee-site-generator*_
that will either regenerate the files without _*Google Analytics*_ or delete
them.
If we take two files in _*tomee-site-pub*_ ias examples:
h2. 1) activemqresourceadapter-config.html
* From the git logs of _*tomee-site-pub*_ this file was last modified on *May
29th 2016* in commit c57faa46a16c4a9d58404588688e145b73a9262b
* From the git logs of _*tomee-site-generator*_ there are no files starting
with *_activemqresourceadapter-config_* since the old website was imported into
this repository on *Jul 4th 2017*
So my conclusion is that there was never a file in _*tomee-site-generator*_
that generated *_activemqresourceadapter-config.html_* in
{_}*tomee-site-pub*{_}. What actions in _*tomee-site-generator*_ can I do in a
PR that will either remove this file or fix it so it doesn't have a reference
to google analytics?
h2. 2) security/index.html
* From the git logs of _*tomee-site-generator*_ I can see that file
_*src/main/jbake/content/security/index.adoc*_
** added on *Jul 4th 2017* in commit *972cc3567a8009690445f18ffc10ce8b14e962ab*
** deleted on *Dec 26th 2018* in commit
*17b7804bc74fbd94d552988efe82771531a82847*
* My assumption was that the above file is what _*security/index.html*_ was
generated from in {_}*tomee-site-pub*{_}, however there are no commits to
*_security/index.html_* on the above dates in _*tomee-site-pub,*_ instead we
have a series of commits that all have a log message that indicates it comes
from Subversion:
{code:java}
Publishing svnmucc operation to tomee site by dblevins
git-svn-id:
https://svn.apache.org/repos/infra/websites/production/tomee/content@1037643
90ea9780-b833-de11-8433-001ec94261de{code}
* Heres the last few commits on that file that all have that type of log
message
** *Jul 6th 2020* 43cf80e624a0cecf0f38bef5ef2614bfb2410f57
** *Dec 9th 2018* 8b984744b7d3f12013546be84c34a51ca9396c0b
** *Dec 2nd 2018* f4935be2f944d613f11ff6d152db4ee0b00df6ff
** *Oct 10th 2017* 1864b538ab9d98864f9733770cf7b93cbd7c934f
** *Jul 11th 2017* d43aab208316de2119c1d7b7215f97f7c65258ed
** *Jun 27th 2017* c2f9000129ecc2dfe8aec0e26578782deeec4f75
So this is now confusing since the initial import of the website in
_*tomee-site-generator*_ was on Jul 4th 2017, but the _*security/index.html*_
file has been published from a _*subversion*_ repo as lates as {*}July 2020{*}?
It leaves several questions:
* Is this file still managed from subversion?
** If so, I guess I should submit a patch to svn to remove GA?
* Or is this updating from subversion a mistake, all the sources should be in
_*tomee-site-generator*_
** If thats the case, since there is no source file, I guess it needs to be
deleted? What action in a PR can I submit to _*tomee-site-generator*_ so that
the security/index.html file is deleted from _*tomee-site-pub?*_
Thanks
Niall
> Remove Google Analytics from Tomee Website
> ------------------------------------------
>
> Key: TOMEE-4448
> URL: https://issues.apache.org/jira/browse/TOMEE-4448
> Project: TomEE
> Issue Type: Task
> Components: Website
> Reporter: Niall Pemberton
> Priority: Major
> Labels: pull-request-available
>
> Hi Tomee Team,
> Although you have migrated from {_}*Google Analytics*{_}(GA) to _*Matomo*_
> (thanks for doing that!) there are still *743 pages* that use GA.
> I have compared what is the files in the two locations below and all except
> five files no longer exist in _*tomee-site-generator*_ - so I'm assuming
> these are old files no longer required:
> *
> [https://github.com/apache/tomee-site-generator/tree/main/src/main/jbake/content]
> * [https://github.com/apache/tomee-site-pub]
> I will submit a PR against the _*tomee-site-pub*_ repo that does the
> following:
> * Removes Google Analytics from the following five files that still exist in
> both locations
> ** features.html
> ** dev/index.html
> ** dev/jira/index.html
> ** dev/jira/patches.html
> ** dev/jira/todo.html
> * Deletes the following folders (and their contents) that no longer exist:
> ** admin
> ** advanced
> ** application-composer
> ** community/contributorsguides
> ** contrib
> ** deamon
> ** developer
> ** download
> ** examples
> ** examples-trunk
> ** latest
> ** master
> ** maven
> ** misc
> * Deletes 288 HTML files that no longer exist
> It would be much appreciated if you could action this to remove Google
> Analytics from the Tomee website
> Thanks
> Niall
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
