Richard Zowalla created TOMEE-4734:
--------------------------------------
Summary: Replace commons-dbcp2 shade with tomcat-dbcp and remove
BoneCP
Key: TOMEE-4734
URL: https://issues.apache.org/jira/browse/TOMEE-4734
Project: TomEE
Issue Type: Improvement
Reporter: Richard Zowalla
Fix For: 11.0.0
TomEE currently ships and maintains its own DBCP copy
\(deps/commons\-dbcp2\-shade, which only relocates javax.transaction to
jakarta.transaction\) plus commons\-pool2, and still has the BoneCP integration
\(server/openejb\-bonecp, BoneCP 0.8.0.RELEASE, unmaintained since 2013\).
Tomcat already ships tomcat\-dbcp.jar in every distribution's lib. It is
Commons DBCP2 / Pool2 repackaged under org.apache.tomcat.dbcp.dbcp2 /
org.apache.tomcat.dbcp.pool2, its managed package is already on
jakarta.transaction, it contains every DBCP2/Pool2 class TomEE uses \(including
the transactionRegistry field set by reflection in BasicManagedDataSource /
DbcpManagedDataSource\), and org.apache.tomcat:tomcat\-dbcp only depends on
tomcat\-juli.
Proposed changes for 11.0.0:
\* Switch org.apache.openejb.resource.jdbc.dbcp \(and tests\) from
org.apache.commons.dbcp2/pool2 to org.apache.tomcat.dbcp.dbcp2/pool2
\* openejb\-core depends on org.apache.tomcat:tomcat\-dbcp
\(${tomcat.version}\) instead of commons\-dbcp2\-shade and commons\-pool2, so
embedded OpenEJB keeps DBCP without Tomcat
\* Remove the deps/commons\-dbcp2\-shade module and drop commons\-dbcp2\-shade
/ commons\-pool2 from the BOMs, webapp poms, dependency management and
openejb\-hsql
\* Update ContainerClassesFilter / URLClassLoaderFirst package entries and
SECURITY.md
\* Remove server/openejb\-bonecp and the bonecp DataSource creator, docs
included
Unchanged: tomcat\-jdbc stays the default pool in TomEE, the dbcp /
dbcp\-alternative creators, DBCP property names and XA support stay as they are.
User\-visible change: code casting to org.apache.commons.dbcp2.BasicDataSource
needs to use org.apache.tomcat.dbcp.dbcp2.BasicDataSource. The DBCP version
follows the Tomcat release.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)