This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 55cd825 Avoid showing a details element when there are no check
results
55cd825 is described below
commit 55cd8250a8173f6b999eb9968a5bb7e522b67cab
Author: Sean B. Palmer <s...@miscoranda.com>
AuthorDate: Thu Apr 3 15:24:46 2025 +0100
Avoid showing a details element when there are no check results
---
atr/templates/draft-review-path.html | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/atr/templates/draft-review-path.html
b/atr/templates/draft-review-path.html
index 87cc96b..57a52f7 100644
--- a/atr/templates/draft-review-path.html
+++ b/atr/templates/draft-review-path.html
@@ -111,14 +111,14 @@
{% if check_result.message %}<div class="mt-2">{{
check_result.message }}</div>{% endif %}
- {% if check_result.data is mapping %}
+ {% if (check_result.data is mapping) and
(check_result.data.keys()|length > 0) %}
<details class="mt-2 p-2 bg-light rounded">
{% if check_result.status.value in ["failure", "exception"] %}
- <summary class="atr-cursor-pointer user-select-none
p-2">View details ({{ check_result.status.value|title }})</summary>
+ <summary class="atr-cursor-pointer user-select-none
p-2">View details</summary>
{% elif check_result.status.value == "warning" %}
- <summary class="atr-cursor-pointer user-select-none
p-2">View details (Warning)</summary>
+ <summary class="atr-cursor-pointer user-select-none
p-2">View details</summary>
{% else %}
- <summary class="atr-cursor-pointer user-select-none
p-2">View detailed results</summary>
+ <summary class="atr-cursor-pointer user-select-none
p-2">View details</summary>
{% endif %}
{% if check_result.checker.endswith("rat.check_licenses") %}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@tooling.apache.org
For additional commands, e-mail: commits-h...@tooling.apache.org
