This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-release.git
The following commit(s) were added to refs/heads/main by this push:
new 3ace80d Remove unused code to delete metadata that is no longer set
3ace80d is described below
commit 3ace80d30bd5a83b2b2c319137d9650e6cac151f
Author: Sean B. Palmer <[email protected]>
AuthorDate: Fri May 30 16:54:15 2025 +0100
Remove unused code to delete metadata that is no longer set
---
atr/blueprints/admin/admin.py | 4 ----
atr/routes/draft.py | 3 ---
atr/routes/preview.py | 6 ------
3 files changed, 13 deletions(-)
diff --git a/atr/blueprints/admin/admin.py b/atr/blueprints/admin/admin.py
index 69e30a2..a594197 100644
--- a/atr/blueprints/admin/admin.py
+++ b/atr/blueprints/admin/admin.py
@@ -484,10 +484,6 @@ async def _delete_release_data(release_name: str) -> None:
await data.delete(check)
_LOGGER.debug("Deleted %d check results for %s",
len(checks_to_delete), release_name)
- await data.ns_text_del_all(release_name + " draft")
- await data.ns_text_del_all(release_name + " preview")
- _LOGGER.debug("Deleted parent links for %s", release_name)
-
await data.delete(release)
_LOGGER.info("Deleted release record: %s", release_name)
await data.commit()
diff --git a/atr/routes/draft.py b/atr/routes/draft.py
index 6d0cb4c..d5a5739 100644
--- a/atr/routes/draft.py
+++ b/atr/routes/draft.py
@@ -514,8 +514,5 @@ async def _delete_candidate_draft(data: db.Session,
candidate_draft_name: str) -
if release.phase != models.ReleasePhase.RELEASE_CANDIDATE_DRAFT:
raise routes.FlashError("Candidate draft is not in the release
candidate draft phase")
- # Delete any parent links
- await data.ns_text_del_all(release.name + " draft")
- await data.ns_text_del_all(release.name + " preview")
# Delete the release record
await data.delete(release)
diff --git a/atr/routes/preview.py b/atr/routes/preview.py
index ccedcdb..8eeb713 100644
--- a/atr/routes/preview.py
+++ b/atr/routes/preview.py
@@ -209,11 +209,5 @@ async def _delete_preview(data: db.Session, preview_name:
str) -> None:
if release.phase != models.ReleasePhase.RELEASE_PREVIEW:
raise routes.FlashError("Release is not in the preview phase")
- # TODO: Abstract this to a function
- # We do something similar in admin.py and draft.py
- # Delete any parent links
- await data.ns_text_del_all(release.name + " draft")
- await data.ns_text_del_all(release.name + " preview")
-
# Delete the release record
await data.delete(release)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
