This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/main by this push:
new 2354576 Only validate archive URLs when set
2354576 is described below
commit 2354576c23a88d408d387cd55446796fcbefe7b3
Author: Sean B. Palmer <[email protected]>
AuthorDate: Tue Oct 28 14:02:10 2025 +0000
Only validate archive URLs when set
---
atr/routes/resolve.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/atr/routes/resolve.py b/atr/routes/resolve.py
index e982e40..dede4be 100644
--- a/atr/routes/resolve.py
+++ b/atr/routes/resolve.py
@@ -196,8 +196,9 @@ async def tabulated_selected_post(session:
route.CommitterSession, project_name:
# Perhaps all hidden fields should be authenticated
# We should also still validate all HMACed fields
archive_url = hidden_form.hidden_field.data or ""
- if not web.valid_url(archive_url, "lists.apache.org"):
- raise base.ASFQuartException("Invalid vote thread URL",
errorcode=400)
+ if archive_url:
+ if not web.valid_url(archive_url, "lists.apache.org"):
+ raise base.ASFQuartException("Invalid vote thread URL",
errorcode=400)
thread_id = archive_url.split("/")[-1]
if thread_id:
try:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]