This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/main by this push:
new f9f01e3 Remove unnecessary type ignore annotations
f9f01e3 is described below
commit f9f01e329bc25baf85ff139e4824c168a842bbd3
Author: Sean B. Palmer <[email protected]>
AuthorDate: Sun Nov 16 18:37:59 2025 +0000
Remove unnecessary type ignore annotations
---
atr/admin/__init__.py | 2 +-
atr/models/helpers.py | 4 ++--
atr/models/sql.py | 6 +++---
atr/post/draft.py | 2 +-
atr/post/revisions.py | 2 +-
atr/shared/__init__.py | 8 ++++----
atr/storage/writers/announce.py | 2 +-
atr/storage/writers/release.py | 4 +---
atr/storage/writers/revision.py | 10 +++++-----
atr/tarzip.py | 2 +-
atr/util.py | 2 +-
11 files changed, 21 insertions(+), 23 deletions(-)
diff --git a/atr/admin/__init__.py b/atr/admin/__init__.py
index b9bbbf4..a3795bd 100644
--- a/atr/admin/__init__.py
+++ b/atr/admin/__init__.py
@@ -744,7 +744,7 @@ async def task_times(
async with db.session() as data:
tasks = await data.task(
project_name=project_name, version_name=version_name,
revision_number=revision_number
- ).all() # type: ignore[reportOptionalMemberAccess]
+ ).all()
for task in tasks:
if (task.started is None) or (task.completed is None):
continue
diff --git a/atr/models/helpers.py b/atr/models/helpers.py
index 04321e6..c717060 100644
--- a/atr/models/helpers.py
+++ b/atr/models/helpers.py
@@ -80,8 +80,8 @@ def _get_dict_to_list_inner_type_adapter(source_type: Any,
key: str) -> pydantic
# Create proper field definitions for create_model
kargs = {k: (v.annotation, v) for k, v in other_fields.items()}
- inner_model = pydantic.create_model(model_name, **kargs) # type: ignore
- return pydantic.TypeAdapter(dict[Annotated[str, key_field], inner_model])
# type: ignore
+ inner_model = pydantic.create_model(model_name, **kargs) # type:
ignore[arg-type]
+ return pydantic.TypeAdapter(dict[Annotated[str, key_field], inner_model])
def _get_dict_to_list_validator(inner_adapter: pydantic.TypeAdapter[dict[Any,
Any]], key: str) -> Any:
diff --git a/atr/models/sql.py b/atr/models/sql.py
index 5686a78..6d89d51 100644
--- a/atr/models/sql.py
+++ b/atr/models/sql.py
@@ -242,7 +242,7 @@ class UTCDateTime(sqlalchemy.types.TypeDecorator):
cache_ok = True
- def process_bind_param(self, value, dialect): # type: ignore
+ def process_bind_param(self, value, dialect):
if value:
if not isinstance(value, datetime.datetime):
raise ValueError(f"Unexpected value type {type(value)}")
@@ -255,7 +255,7 @@ class UTCDateTime(sqlalchemy.types.TypeDecorator):
else:
return value
- def process_result_value(self, value, dialect): # type: ignore
+ def process_result_value(self, value, dialect):
if isinstance(value, datetime.datetime):
return value.replace(tzinfo=datetime.UTC)
else:
@@ -791,7 +791,7 @@ class Release(sqlmodel.SQLModel, table=True):
return number
# TODO: How do we give an example for this?
- @pydantic.computed_field # type: ignore[prop-decorator]
+ @pydantic.computed_field
@property
def latest_revision_number(self) -> str | None:
"""Get the latest revision number for the release."""
diff --git a/atr/post/draft.py b/atr/post/draft.py
index ad356ac..20abd42 100644
--- a/atr/post/draft.py
+++ b/atr/post/draft.py
@@ -86,7 +86,7 @@ async def delete(session: web.Committer) ->
web.WerkzeugResponse:
# TODO: Confirm that this is a bug, and report upstream
# Changing it to str(...) doesn't work either
# Yet it works in preview.py
- await aioshutil.rmtree(draft_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(draft_dir)
return await session.redirect(get.root.index, success="Candidate draft
deleted successfully")
diff --git a/atr/post/revisions.py b/atr/post/revisions.py
index 0c6a7ad..77ceca5 100644
--- a/atr/post/revisions.py
+++ b/atr/post/revisions.py
@@ -61,7 +61,7 @@ async def selected_post(
project_name, version_name, session.uid, description=description
) as creating:
# TODO: Stop create_and_manage from hard linking the parent first
- await aioshutil.rmtree(creating.interim_path) # type:
ignore[call-arg]
+ await aioshutil.rmtree(creating.interim_path)
await util.create_hard_link_clone(selected_revision_dir,
creating.interim_path)
if creating.new is None:
diff --git a/atr/shared/__init__.py b/atr/shared/__init__.py
index 1e6fb69..ec65f53 100644
--- a/atr/shared/__init__.py
+++ b/atr/shared/__init__.py
@@ -119,12 +119,12 @@ async def check(
ongoing_tasks_count = await interaction.tasks_ongoing(
release.project.name,
release.version,
- revision_number, # type: ignore[arg-type]
+ revision_number,
)
case None:
- revision_number = None # type: ignore[assignment]
- revision_editor = None # type: ignore[assignment]
- revision_timestamp = None # type: ignore[assignment]
+ revision_number = None
+ revision_editor = None
+ revision_timestamp = None
delete_draft_form = await draft.DeleteForm.create_form(
data={"release_name": release.name, "project_name":
release.project.name, "version_name": release.version}
diff --git a/atr/storage/writers/announce.py b/atr/storage/writers/announce.py
index fb6c72a..fc43b97 100644
--- a/atr/storage/writers/announce.py
+++ b/atr/storage/writers/announce.py
@@ -179,7 +179,7 @@ class CommitteeMember(CommitteeParticipant):
)
if unfinished_revisions_path:
# This removes all of the prior revisions
- await aioshutil.rmtree(str(unfinished_revisions_path)) #
type: ignore[call-arg]
+ await aioshutil.rmtree(str(unfinished_revisions_path))
except Exception as e:
raise storage.AccessError(f"Error moving files: {e!s}")
diff --git a/atr/storage/writers/release.py b/atr/storage/writers/release.py
index 2c04822..8db08f0 100644
--- a/atr/storage/writers/release.py
+++ b/atr/storage/writers/release.py
@@ -498,9 +498,7 @@ class CommitteeParticipant(FoundationCommitter):
try:
if await aiofiles.os.path.isdir(release_dir):
log.info("Deleting filesystem directory: %s", release_dir)
- # Believe this to be another bug in mypy Protocol handling
- # TODO: Confirm that this is a bug, and report upstream
- await aioshutil.rmtree(release_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(release_dir)
log.info("Successfully deleted directory: %s", release_dir)
else:
log.warning("Filesystem directory not found, skipping
deletion: %s", release_dir)
diff --git a/atr/storage/writers/revision.py b/atr/storage/writers/revision.py
index 6a26b7f..904625f 100644
--- a/atr/storage/writers/revision.py
+++ b/atr/storage/writers/revision.py
@@ -51,7 +51,7 @@ class SafeSession:
try:
return await self._stack.enter_async_context(self._manager)
except Exception:
- await aioshutil.rmtree(self._temp_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(self._temp_dir)
raise
async def __aexit__(self, _exc_type, _exc, _tb):
@@ -135,18 +135,18 @@ class CommitteeParticipant(FoundationCommitter):
# The directory is either empty or its files are hard linked to
the previous revision
yield creating
except types.FailedError as e:
- await aioshutil.rmtree(temp_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(temp_dir)
creating.failed = e
return
except Exception:
- await aioshutil.rmtree(temp_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(temp_dir)
raise
# Ensure that the permissions of every directory are 755
try:
await asyncio.to_thread(util.chmod_directories, temp_dir_path)
except Exception:
- await aioshutil.rmtree(temp_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(temp_dir)
raise
async with SafeSession(temp_dir) as data:
@@ -186,7 +186,7 @@ class CommitteeParticipant(FoundationCommitter):
# Rename the temporary interim directory to the new revision
number
await aiofiles.os.rename(temp_dir, new_revision_dir)
except Exception:
- await aioshutil.rmtree(temp_dir) # type: ignore[call-arg]
+ await aioshutil.rmtree(temp_dir)
raise
# Commit to end the transaction started by data.begin_immediate
diff --git a/atr/tarzip.py b/atr/tarzip.py
index ae15e3e..391b1cb 100644
--- a/atr/tarzip.py
+++ b/atr/tarzip.py
@@ -29,7 +29,7 @@ ArchiveT = TypeVar("ArchiveT", tarfile.TarFile,
zipfile.ZipFile)
MemberT = TypeVar("MemberT", tarfile.TarInfo, zipfile.ZipInfo, covariant=True)
-class AbstractArchiveMember[MemberT: (tarfile.TarInfo,
zipfile.ZipInfo)](TypingProtocol): # type: ignore[misc]
+class AbstractArchiveMember[MemberT: (tarfile.TarInfo,
zipfile.ZipInfo)](TypingProtocol):
name: str
size: int
linkname: str | None
diff --git a/atr/util.py b/atr/util.py
index b5137ba..4c2fb13 100644
--- a/atr/util.py
+++ b/atr/util.py
@@ -168,7 +168,7 @@ async def async_temporary_directory(
yield pathlib.Path(temp_dir_path)
finally:
try:
- await aioshutil.rmtree(temp_dir_path) # type: ignore[call-arg]
+ await aioshutil.rmtree(temp_dir_path)
except Exception:
pass
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
