This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/main by this push:
new f7e8294 Fix a bug where signatures are duplicated on vote resolution
emails
f7e8294 is described below
commit f7e82940c2dbd04846d89d9e3243e3ac83526e98
Author: Sean B. Palmer <[email protected]>
AuthorDate: Sun Dec 7 10:56:40 2025 +0000
Fix a bug where signatures are duplicated on vote resolution emails
---
atr/storage/writers/vote.py | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/atr/storage/writers/vote.py b/atr/storage/writers/vote.py
index eb41204..ce2aa65 100644
--- a/atr/storage/writers/vote.py
+++ b/atr/storage/writers/vote.py
@@ -418,10 +418,18 @@ class CommitteeMember(CommitteeParticipant):
email_recipient = latest_vote_task.task_args["email_to"]
email_sender = f"{asf_uid}@apache.org"
subject = f"[VOTE] [RESULT] Release {release.project.display_name}
{release.version} {resolution.upper()}"
- signature = f"-- \n{asf_fullname} ({asf_uid})"
- if asf_fullname == asf_uid:
- signature = f"-- \n{asf_fullname}"
- body = f"{body}\n\n{signature}"
+ # TODO: This duplicates atr/tabulate.py code
+ # There are arguments for using this code instead:
+ # - It enforces a consistent style
+ # - It can't be edited by the user
+ # - It could be made conditional based on user input
+ # But users might not know whether to use a signature or not
+ # And they may not use a standard format that can be detected
+ # Therefore we don't add a signature here
+ # signature = f"-- \n{asf_fullname} ({asf_uid})"
+ # if asf_fullname == asf_uid:
+ # signature = f"-- \n{asf_fullname}"
+ # body = f"{body}\n\n{signature}"
in_reply_to = vote_thread_mid
task = sql.Task(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
