This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/sbp by this push:
new 96397103 Migrate revision creators that clone without modifications
96397103 is described below
commit 96397103f8c864d70ad4e43d8ead86ad77eaf4e5
Author: Sean B. Palmer <[email protected]>
AuthorDate: Wed Feb 18 14:51:29 2026 +0000
Migrate revision creators that clone without modifications
---
atr/post/draft.py | 10 +++-------
atr/storage/writers/release.py | 5 +----
atr/storage/writers/vote.py | 10 ++++------
3 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/atr/post/draft.py b/atr/post/draft.py
index 3ca61bc4..5568081b 100644
--- a/atr/post/draft.py
+++ b/atr/post/draft.py
@@ -104,10 +104,7 @@ async def fresh(session: web.Committer, project_name: str,
version_name: str) ->
description = "Empty revision to restart all checks for the whole release
candidate draft"
async with storage.write(session) as write:
wacp = await write.as_project_committee_participant(project_name)
- async with wacp.revision.create_and_manage(
- project_name, version_name, session.uid, description=description
- ) as _creating:
- pass
+ await wacp.revision.create_revision(project_name, version_name,
session.uid, description=description)
return await session.redirect(
get.compose.selected,
@@ -157,14 +154,13 @@ async def recheck(session: web.Committer, project_name:
str, version_name: str)
description = "Empty revision to restart all checks without cache for the
whole release candidate draft"
async with storage.write(session) as write:
wacp = await write.as_project_committee_participant(project_name)
- async with wacp.revision.create_and_manage(
+ await wacp.revision.create_revision(
project_name,
version_name,
session.uid,
description=description,
use_check_cache=False,
- ) as _creating:
- pass
+ )
return await session.redirect(
get.compose.selected,
diff --git a/atr/storage/writers/release.py b/atr/storage/writers/release.py
index 0bcc836b..d0753546 100644
--- a/atr/storage/writers/release.py
+++ b/atr/storage/writers/release.py
@@ -414,10 +414,7 @@ class CommitteeParticipant(FoundationCommitter):
await self.__data.refresh(release)
description = "Creation of empty release candidate draft through web
interface"
- async with self.__write_as.revision.create_and_manage(
- project_name, version, self.__asf_uid, description=description
- ) as _creating:
- pass
+ await self.__write_as.revision.create_revision(project_name, version,
self.__asf_uid, description=description)
self.__write_as.append_to_audit_log(
asf_uid=self.__asf_uid,
project_name=project_name,
diff --git a/atr/storage/writers/vote.py b/atr/storage/writers/vote.py
index 4d0ab346..ecb4f03d 100644
--- a/atr/storage/writers/vote.py
+++ b/atr/storage/writers/vote.py
@@ -283,10 +283,9 @@ class CommitteeMember(CommitteeParticipant):
success_message = "Vote marked as passed"
description = "Create a preview revision from the last candidate
draft"
- async with self.__write_as.revision.create_and_manage(
+ await self.__write_as.revision.create_revision(
project_name, release.version, self.__asf_uid,
description=description
- ) as _creating:
- pass
+ )
else:
release.phase = sql.ReleasePhase.RELEASE_CANDIDATE_DRAFT
await self.__data.commit()
@@ -371,10 +370,9 @@ class CommitteeMember(CommitteeParticipant):
success_message = "Vote marked as passed"
description = "Create a preview revision from the last candidate
draft"
- async with self.__write_as.revision.create_and_manage(
+ await self.__write_as.revision.create_revision(
project_name, release.version, self.__asf_uid,
description=description
- ) as _creating:
- pass
+ )
if (voting_round == 2) and (release.podling_thread_id is not None):
round_one_email_address, round_one_message_id = await
util.email_mid_from_thread_id(
release.podling_thread_id
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
