This is an automated email from the ASF dual-hosted git repository.

sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git


The following commit(s) were added to refs/heads/sbp by this push:
     new 32d79d70 Make compose phase tests less fragile
32d79d70 is described below

commit 32d79d70ca3b74c9a0086420fb9bf463d273c2cd
Author: Sean B. Palmer <[email protected]>
AuthorDate: Wed Feb 18 15:32:58 2026 +0000

    Make compose phase tests less fragile
---
 tests/e2e/compose/test_get.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/tests/e2e/compose/test_get.py b/tests/e2e/compose/test_get.py
index 5942ba88..e807eb11 100644
--- a/tests/e2e/compose/test_get.py
+++ b/tests/e2e/compose/test_get.py
@@ -55,7 +55,8 @@ def 
test_ongoing_tasks_banner_appears_when_tasks_restart(page_compose: Page) ->
     expect(banner).to_be_hidden()
 
     restart_button = page_compose.get_by_role("button", name="Restart all 
checks")
-    restart_button.click()
+    with page_compose.expect_navigation():
+        restart_button.click()
 
     expect(banner).to_be_visible(timeout=10000)
 
@@ -63,7 +64,8 @@ def 
test_ongoing_tasks_banner_appears_when_tasks_restart(page_compose: Page) ->
 def test_ongoing_tasks_banner_has_progress_bar(page_compose: Page) -> None:
     """The ongoing tasks banner should have a progress bar."""
     restart_button = page_compose.get_by_role("button", name="Restart all 
checks")
-    restart_button.click()
+    with page_compose.expect_navigation():
+        restart_button.click()
 
     progress_bar = page_compose.locator("#poll-progress")
     expect(progress_bar).to_be_visible(timeout=10000)
@@ -72,7 +74,8 @@ def test_ongoing_tasks_banner_has_progress_bar(page_compose: 
Page) -> None:
 def test_ongoing_tasks_banner_has_task_count(page_compose: Page) -> None:
     """The ongoing tasks banner should display the task count."""
     restart_button = page_compose.get_by_role("button", name="Restart all 
checks")
-    restart_button.click()
+    with page_compose.expect_navigation():
+        restart_button.click()
 
     banner = page_compose.locator("#ongoing-tasks-banner")
     expect(banner).to_be_visible(timeout=10000)
@@ -84,7 +87,8 @@ def test_ongoing_tasks_banner_has_task_count(page_compose: 
Page) -> None:
 def test_ongoing_tasks_banner_has_warning_icon(page_compose: Page) -> None:
     """The ongoing tasks banner should have a warning icon when visible."""
     restart_button = page_compose.get_by_role("button", name="Restart all 
checks")
-    restart_button.click()
+    with page_compose.expect_navigation():
+        restart_button.click()
 
     warning_icon = page_compose.locator("#ongoing-tasks-banner 
i.bi-exclamation-triangle")
     expect(warning_icon).to_be_visible(timeout=10000)


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to