This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/sbp by this push:
new 26ef4a14 Remove the release policy option to pause for the release
manager
26ef4a14 is described below
commit 26ef4a14fe4ed6803f7d0fc84f20f9fcabf104fe
Author: Sean B. Palmer <[email protected]>
AuthorDate: Wed Mar 25 15:18:33 2026 +0000
Remove the release policy option to pause for the release manager
---
atr/api/__init__.py | 1 -
atr/db/__init__.py | 3 ---
atr/get/projects.py | 1 -
atr/models/api.py | 2 --
atr/models/sql.py | 8 --------
atr/shared/projects.py | 4 ----
atr/storage/writers/policy.py | 1 -
migrations/versions/0062_2026.03.25_5bc8d2ef.py | 27 +++++++++++++++++++++++++
8 files changed, 27 insertions(+), 20 deletions(-)
diff --git a/atr/api/__init__.py b/atr/api/__init__.py
index 206830d5..a8ce0a7d 100644
--- a/atr/api/__init__.py
+++ b/atr/api/__init__.py
@@ -719,7 +719,6 @@ async def policy_get(
policy_mailto_addresses=project.policy_mailto_addresses,
policy_manual_vote=project.policy_manual_vote,
policy_min_hours=project.policy_min_hours,
- policy_pause_for_rm=project.policy_pause_for_rm,
policy_preserve_download_files=project.policy_preserve_download_files,
policy_release_checklist=project.policy_release_checklist,
policy_source_artifact_paths=project.policy_source_artifact_paths,
diff --git a/atr/db/__init__.py b/atr/db/__init__.py
index 78c03332..6b96fb1a 100644
--- a/atr/db/__init__.py
+++ b/atr/db/__init__.py
@@ -706,7 +706,6 @@ class Session(sqlalchemy.ext.asyncio.AsyncSession):
manual_vote: Opt[bool] = NOT_SET,
min_hours: Opt[int] = NOT_SET,
release_checklist: Opt[str] = NOT_SET,
- pause_for_rm: Opt[bool] = NOT_SET,
github_repository_name: Opt[str] = NOT_SET,
github_compose_workflow_path: Opt[list[str]] = NOT_SET,
github_vote_workflow_path: Opt[list[str]] = NOT_SET,
@@ -729,8 +728,6 @@ class Session(sqlalchemy.ext.asyncio.AsyncSession):
query = query.where(sql.ReleasePolicy.min_hours == min_hours)
if is_defined(release_checklist):
query = query.where(sql.ReleasePolicy.release_checklist ==
release_checklist)
- if is_defined(pause_for_rm):
- query = query.where(sql.ReleasePolicy.pause_for_rm == pause_for_rm)
if is_defined(github_repository_name):
query = query.where(sql.ReleasePolicy.github_repository_name ==
github_repository_name)
if is_defined(github_compose_workflow_path):
diff --git a/atr/get/projects.py b/atr/get/projects.py
index 4ad788ce..045998cd 100644
--- a/atr/get/projects.py
+++ b/atr/get/projects.py
@@ -650,7 +650,6 @@ def _render_vote_form(project: sql.Project) -> htm.Element:
else f"dev@{project.key}.apache.org",
"manual_vote": project.policy_manual_vote,
"min_hours": project.policy_min_hours,
- "pause_for_rm": project.policy_pause_for_rm,
"release_checklist": project.policy_release_checklist or "",
"vote_comment_template": project.policy_vote_comment_template or "",
"start_vote_subject": project.policy_start_vote_subject or "",
diff --git a/atr/models/api.py b/atr/models/api.py
index 75c0f710..05f15fa6 100644
--- a/atr/models/api.py
+++ b/atr/models/api.py
@@ -302,7 +302,6 @@ class PolicyGetResults(schema.Strict):
policy_mailto_addresses: list[str]
policy_manual_vote: bool
policy_min_hours: int
- policy_pause_for_rm: bool
policy_preserve_download_files: bool
policy_release_checklist: str
policy_source_artifact_paths: list[str]
@@ -327,7 +326,6 @@ class PolicyUpdateArgs(schema.Strict):
mailto_addresses: list[str] | None = None
manual_vote: bool | None = None
min_hours: int | None = None
- pause_for_rm: bool | None = None
preserve_download_files: bool | None = None
release_checklist: str | None = None
source_artifact_paths: list[str] | None = None
diff --git a/atr/models/sql.py b/atr/models/sql.py
index 9320c23e..64e20091 100644
--- a/atr/models/sql.py
+++ b/atr/models/sql.py
@@ -752,12 +752,6 @@ Thanks,
return self.policy_default_min_hours
return policy.min_hours
- @property
- def policy_pause_for_rm(self) -> bool:
- if (policy := self.release_policy) is None:
- return False
- return policy.pause_for_rm
-
@property
def policy_release_checklist(self) -> str:
if ((policy := self.release_policy) is None) or
(policy.release_checklist == ""):
@@ -1300,7 +1294,6 @@ class ReleasePolicy(sqlmodel.SQLModel, table=True):
min_hours: int | None = sqlmodel.Field(default=None)
release_checklist: str = sqlmodel.Field(default="")
vote_comment_template: str = sqlmodel.Field(default="")
- pause_for_rm: bool = sqlmodel.Field(default=False)
start_vote_subject: str = sqlmodel.Field(default="")
start_vote_template: str = sqlmodel.Field(default="")
announce_release_subject: str = sqlmodel.Field(default="")
@@ -1347,7 +1340,6 @@ class ReleasePolicy(sqlmodel.SQLModel, table=True):
min_hours=self.min_hours,
release_checklist=self.release_checklist,
vote_comment_template=self.vote_comment_template,
- pause_for_rm=self.pause_for_rm,
start_vote_subject=self.start_vote_subject,
start_vote_template=self.start_vote_template,
announce_release_subject=self.announce_release_subject,
diff --git a/atr/shared/projects.py b/atr/shared/projects.py
index 9d6f2abb..b90f7631 100644
--- a/atr/shared/projects.py
+++ b/atr/shared/projects.py
@@ -156,10 +156,6 @@ class VotePolicyForm(form.Form):
"If 0, then wait until 3 +1 votes and more +1 than -1.",
default=72,
)
- pause_for_rm: form.Bool = form.label(
- "Pause for RM",
- "If enabled, RM can confirm manually if the vote has passed.",
- )
release_checklist: str = form.label(
"Release checklist",
widget=form.Widget.CUSTOM,
diff --git a/atr/storage/writers/policy.py b/atr/storage/writers/policy.py
index 67db558a..75af20b1 100644
--- a/atr/storage/writers/policy.py
+++ b/atr/storage/writers/policy.py
@@ -201,7 +201,6 @@ class CommitteeMember(CommitteeParticipant):
if not release_policy.manual_vote:
release_policy.mailto_addresses = [form.mailto_addresses]
self.__set_min_hours(form.min_hours, project, release_policy)
- release_policy.pause_for_rm = form.pause_for_rm
release_policy.release_checklist = form.release_checklist or ""
release_policy.vote_comment_template = form.vote_comment_template
or ""
self.__set_start_vote_subject(form.start_vote_subject or "",
project, release_policy)
diff --git a/migrations/versions/0062_2026.03.25_5bc8d2ef.py
b/migrations/versions/0062_2026.03.25_5bc8d2ef.py
new file mode 100644
index 00000000..0d2d0547
--- /dev/null
+++ b/migrations/versions/0062_2026.03.25_5bc8d2ef.py
@@ -0,0 +1,27 @@
+"""Remove the policy option to pause for the release manager
+
+Revision ID: 0062_2026.03.25_5bc8d2ef
+Revises: 0061_2026.03.18_7838cfcc
+Create Date: 2026-03-25 15:13:05.016111+00:00
+"""
+
+from collections.abc import Sequence
+
+import sqlalchemy as sa
+from alembic import op
+
+# Revision identifiers, used by Alembic
+revision: str = "0062_2026.03.25_5bc8d2ef"
+down_revision: str | None = "0061_2026.03.18_7838cfcc"
+branch_labels: str | Sequence[str] | None = None
+depends_on: str | Sequence[str] | None = None
+
+
+def upgrade() -> None:
+ with op.batch_alter_table("releasepolicy", schema=None) as batch_op:
+ batch_op.drop_column("pause_for_rm")
+
+
+def downgrade() -> None:
+ with op.batch_alter_table("releasepolicy", schema=None) as batch_op:
+ batch_op.add_column(sa.Column("pause_for_rm", sa.BOOLEAN(),
nullable=False, server_default=sa.false()))
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
