This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/sbp by this push:
new 3ca91532 Fix validation of release vote properties
3ca91532 is described below
commit 3ca91532f36e14ba22172455047e1d8e256b946e
Author: Sean B. Palmer <[email protected]>
AuthorDate: Fri Apr 3 19:44:31 2026 +0100
Fix validation of release vote properties
---
atr/validate.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/atr/validate.py b/atr/validate.py
index d6c7bbd2..81bd660a 100644
--- a/atr/validate.py
+++ b/atr/validate.py
@@ -377,11 +377,13 @@ def release_vote_logic(r: sql.Release) -> Divergences:
def okay(sr: tuple[datetime.datetime | None, datetime.datetime | None]) ->
bool:
# The vote_resolved property must not be set unless vote_started is set
match sr:
- case (None, None) | (_, None) | (_, _):
+ case (None, None) | (_, None):
+ return True
+ case (None, _):
+ # Resolved without being started
+ return False
+ case (_, _):
return True
- # case (None, _):
- # return False
- return False
expected = "vote_started to be set when vote_resolved is set"
actual = (r.vote_started, r.vote_resolved)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
