Repository: trafficserver Updated Branches: refs/heads/master 61cbc5b95 -> e71350b4b
Resolve coverity #1325735, #1325734, #1325736 Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/e71350b4 Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/e71350b4 Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/e71350b4 Branch: refs/heads/master Commit: e71350b4b9c8abc3a81432c203accca03ed172e1 Parents: 61cbc5b Author: Brian Geffon <bri...@apache.org> Authored: Tue Oct 6 06:43:58 2015 -0700 Committer: Brian Geffon <bri...@apache.org> Committed: Tue Oct 6 06:49:31 2015 -0700 ---------------------------------------------------------------------- plugins/header_rewrite/header_rewrite_test.cc | 2 ++ plugins/header_rewrite/parser.cc | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e71350b4/plugins/header_rewrite/header_rewrite_test.cc ---------------------------------------------------------------------- diff --git a/plugins/header_rewrite/header_rewrite_test.cc b/plugins/header_rewrite/header_rewrite_test.cc index 4c836e4..ff78beb 100644 --- a/plugins/header_rewrite/header_rewrite_test.cc +++ b/plugins/header_rewrite/header_rewrite_test.cc @@ -37,6 +37,7 @@ TSError(const char *fmt, ...) if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) { fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf); } + va_end(args); } extern "C" void @@ -49,6 +50,7 @@ TSDebug(const char *tag, const char *fmt, ...) if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) { fprintf(stdout, "TSDebug: %s: %.*s\n", PLUGIN_NAME, bytes, buf); } + va_end(args); } #define CHECK_EQ(x, y) \ http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e71350b4/plugins/header_rewrite/parser.cc ---------------------------------------------------------------------- diff --git a/plugins/header_rewrite/parser.cc b/plugins/header_rewrite/parser.cc index 43ead4a..609b5be 100644 --- a/plugins/header_rewrite/parser.cc +++ b/plugins/header_rewrite/parser.cc @@ -69,9 +69,6 @@ Parser::Parser(const std::string &line) : _cond(false), _empty(false) return; } } else if (!extracting_token) { - if (inquote) - continue; /* just keep eating until we hit the closing quote */ - if (_tokens.empty() && line[i] == '#') { // this is a comment line (it may have had leading whitespace before the #) _empty = true;
