[trafficserver] branch master updated: cppcheck: fixes issues in ink_uuid.h (BROKEN)

[rrm]

This is an automated email from the ASF dual-hosted git repository.

rrm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 1b84e2a  cppcheck: fixes issues in ink_uuid.h (BROKEN)
1b84e2a is described below

commit 1b84e2a45a25f1af903304ee2cc07dd13e295684
Author: Randall Meyer <randallme...@yahoo.com>
AuthorDate: Wed Apr 24 07:14:07 2019 +0800

    cppcheck: fixes issues in ink_uuid.h (BROKEN)
    
    Function parameter 'other' should be passed by const reference.
---
 include/tscore/ink_uuid.h | 2 +-
 src/tscore/ink_uuid.cc    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/tscore/ink_uuid.h b/include/tscore/ink_uuid.h
index 32127dc..7106d24 100644
--- a/include/tscore/ink_uuid.h
+++ b/include/tscore/ink_uuid.h
@@ -34,7 +34,7 @@ class ATSUuid
 public:
   // Constructors
   ATSUuid() {}
-  ATSUuid &operator=(const ATSUuid other);
+  ATSUuid &operator=(const ATSUuid &other);
 
   // Initialize the UUID from a string
   bool parseString(const char *str);
diff --git a/src/tscore/ink_uuid.cc b/src/tscore/ink_uuid.cc
index 92266cd..e2a56f0 100644
--- a/src/tscore/ink_uuid.cc
+++ b/src/tscore/ink_uuid.cc
@@ -52,7 +52,7 @@ ATSUuid::initialize(TSUuidVersion v)
 
 // Copy assignment
 ATSUuid &
-ATSUuid::operator=(const ATSUuid other)
+ATSUuid::operator=(const ATSUuid &other)
 {
   memcpy(_uuid.data, other._uuid.data, sizeof(_uuid.data));
   memcpy(_string, other._string, sizeof(_string));