This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new ff71095  Enable logging autests on macOS, clarify why Linux is required
ff71095 is described below

commit ff71095359e9067e7843a739bbf1ba9697aa240c
Author: Randall Meyer <r...@apache.org>
AuthorDate: Tue Mar 24 10:51:59 2020 -0700

    Enable logging autests on macOS, clarify why Linux is required
    
    also gitignore 'done' file generated when test runs are interrupted
    
    (cherry picked from commit e4c8e6c439f0f9d606a2b31c4eb7ec85be25da7d)
---
 tests/.gitignore                              | 1 +
 tests/gold_tests/logging/custom-log.test.py   | 3 ++-
 tests/gold_tests/logging/log-field.test.py    | 6 ------
 tests/gold_tests/logging/log-filter.test.py   | 6 ------
 tests/gold_tests/logging/new_log_flds.test.py | 2 +-
 5 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/tests/.gitignore b/tests/.gitignore
index 4cbfa0f..bafde3c 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -1 +1,2 @@
 _sandbox/
+done
diff --git a/tests/gold_tests/logging/custom-log.test.py 
b/tests/gold_tests/logging/custom-log.test.py
index 6dd132b..e8799d3 100644
--- a/tests/gold_tests/logging/custom-log.test.py
+++ b/tests/gold_tests/logging/custom-log.test.py
@@ -21,7 +21,8 @@ import os
 Test.Summary = '''
 Test custom log file format
 '''
-# need Curl
+
+# this test depends on Linux specific behavior regarding loopback addresses
 Test.SkipUnless(
     Condition.IsPlatform("linux")
 )
diff --git a/tests/gold_tests/logging/log-field.test.py 
b/tests/gold_tests/logging/log-field.test.py
index b9997c7..784d220 100644
--- a/tests/gold_tests/logging/log-field.test.py
+++ b/tests/gold_tests/logging/log-field.test.py
@@ -21,14 +21,8 @@ import os
 Test.Summary = '''
 Test log fields.
 '''
-# Only on Linux (why??)
-Test.SkipUnless(
-    Condition.IsPlatform("linux")
-)
 
-# Define default ATS
 ts = Test.MakeATSProcess("ts")
-# Microserver
 server = Test.MakeOriginServer("server")
 
 request_header = {'timestamp': 100, "headers": "GET /test-1 HTTP/1.1\r\nHost: 
test-1\r\n\r\n", "body": ""}
diff --git a/tests/gold_tests/logging/log-filter.test.py 
b/tests/gold_tests/logging/log-filter.test.py
index 97dd8ee..771afec 100644
--- a/tests/gold_tests/logging/log-filter.test.py
+++ b/tests/gold_tests/logging/log-filter.test.py
@@ -21,14 +21,8 @@ import os
 Test.Summary = '''
 Test log filter.
 '''
-# Only on Linux (why??)
-Test.SkipUnless(
-    Condition.IsPlatform("linux")
-)
 
-# Define default ATS
 ts = Test.MakeATSProcess("ts")
-# Microserver
 server = Test.MakeOriginServer("server")
 
 request_header = {'timestamp': 100, "headers": "GET /test-1 HTTP/1.1\r\nHost: 
test-1\r\n\r\n", "body": ""}
diff --git a/tests/gold_tests/logging/new_log_flds.test.py 
b/tests/gold_tests/logging/new_log_flds.test.py
index 1f388eb..dbd1922 100644
--- a/tests/gold_tests/logging/new_log_flds.test.py
+++ b/tests/gold_tests/logging/new_log_flds.test.py
@@ -21,7 +21,7 @@ import os
 Test.Summary = '''
 Test new log fields
 '''
-# need Curl
+
 Test.SkipUnless(
     Condition.HasCurlFeature('http2')
 )

Reply via email to