changeset 4496aa6afc97 in sao:default
details: https://hg.tryton.org/sao?cmd=changeset;node=4496aa6afc97
description:
        Reset display_size of TreeView when group is cleared or changed

        This avoids to render unnecessary rows.

        issue8918
        review274591002
diffstat:

 CHANGELOG        |  1 +
 src/screen.js    |  6 ++++++
 src/view.js      |  3 +++
 src/view/tree.js |  4 +++-
 4 files changed, 13 insertions(+), 1 deletions(-)

diffs (72 lines):

diff -r 362d17cf7f04 -r 4496aa6afc97 CHANGELOG
--- a/CHANGELOG Sat Dec 28 17:55:47 2019 +0100
+++ b/CHANGELOG Sat Dec 28 18:07:13 2019 +0100
@@ -1,3 +1,4 @@
+* Reset display_size of TreeView when group is cleared or changed
 * Allow relation field to be selected in CSV export
 * Hide empty cell on small screen
 * Support validate attribute of wizard's Button
diff -r 362d17cf7f04 -r 4496aa6afc97 src/screen.js
--- a/src/screen.js     Sat Dec 28 17:55:47 2019 +0100
+++ b/src/screen.js     Sat Dec 28 18:07:13 2019 +0100
@@ -1156,6 +1156,9 @@
             }
             group.screens.push(this);
             this.tree_states_done = [];
+            this.views.map(function(view) {
+                view.reset();
+            });
             this.order = null;
             this.group = group;
             this.model = group.model;
@@ -1329,6 +1332,9 @@
         clear: function() {
             this.current_record = null;
             this.group.clear();
+            this.views.map(function(view) {
+                view.reset();
+            });
         },
         default_row_activate: function() {
             if ((this.current_view.view_type == 'tree') &&
diff -r 362d17cf7f04 -r 4496aa6afc97 src/view.js
--- a/src/view.js       Sat Dec 28 17:55:47 2019 +0100
+++ b/src/view.js       Sat Dec 28 18:07:13 2019 +0100
@@ -34,6 +34,7 @@
                     this, this.screen.exclude_field, field_attrs)
                     .parse(xml.children()[0]);
             }
+            this.reset();
         },
         set_value: function() {
         },
@@ -55,6 +56,8 @@
         get_buttons: function() {
             return [];
         },
+        reset: function() {
+        },
     });
 
     Sao.View.idpath2path = function(tree, idpath) {
diff -r 362d17cf7f04 -r 4496aa6afc97 src/view/tree.js
--- a/src/view/tree.js  Sat Dec 28 17:55:47 2019 +0100
+++ b/src/view/tree.js  Sat Dec 28 18:07:13 2019 +0100
@@ -89,6 +89,7 @@
         view_type: 'tree',
         xml_parser: Sao.View.TreeXMLViewParser,
         draggable: false,
+        display_size: Sao.config.display_size,
         init: function(view_id, screen, xml, children_field) {
             this.children_field = children_field;
             this.sum_widgets = {};
@@ -211,7 +212,8 @@
             this.table.append(this.tbody);
 
             this.set_drag_and_drop();
-
+        },
+        reset: function() {
             this.display_size = Sao.config.display_size;
         },
         get editable() {

Reply via email to