changeset c825a39dd9c6 in modules/sale_price_list:default
details:
https://hg.tryton.org/modules/sale_price_list?cmd=changeset;node=c825a39dd9c6
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 12 ++++++------
configuration.py | 2 --
party.py | 2 --
sale.py | 8 +++-----
setup.py | 7 ++++---
tests/__init__.py | 2 +-
7 files changed, 16 insertions(+), 19 deletions(-)
diffs (128 lines):
diff -r d5bd02d543d5 -r c825a39dd9c6 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r d5bd02d543d5 -r c825a39dd9c6 __init__.py
--- a/__init__.py Sun Feb 23 13:55:00 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,18 +2,18 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .party import *
-from .sale import *
+from . import party
+from . import sale
from . import product
from . import configuration
def register():
Pool.register(
- Party,
- PartySalePriceList,
- Sale,
- SaleLine,
+ party.Party,
+ party.PartySalePriceList,
+ sale.Sale,
+ sale.Line,
product.Product,
product.PriceList,
product.SaleContext,
diff -r d5bd02d543d5 -r c825a39dd9c6 configuration.py
--- a/configuration.py Sun Feb 23 13:55:00 2020 +0100
+++ b/configuration.py Sun Mar 01 12:33:53 2020 +0100
@@ -6,8 +6,6 @@
from trytond.modules.company.model import (
CompanyMultiValueMixin, CompanyValueMixin)
-__all__ = ['Configuration', 'ConfigurationSalePriceList']
-
class Configuration(CompanyMultiValueMixin, metaclass=PoolMeta):
__name__ = 'sale.configuration'
diff -r d5bd02d543d5 -r c825a39dd9c6 party.py
--- a/party.py Sun Feb 23 13:55:00 2020 +0100
+++ b/party.py Sun Mar 01 12:33:53 2020 +0100
@@ -8,8 +8,6 @@
from trytond.modules.company.model import (
CompanyMultiValueMixin, CompanyValueMixin)
-__all__ = ['Party', 'PartySalePriceList']
-
class Party(CompanyMultiValueMixin, metaclass=PoolMeta):
__name__ = 'party.party'
diff -r d5bd02d543d5 -r c825a39dd9c6 sale.py
--- a/sale.py Sun Feb 23 13:55:00 2020 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pyson import Eval, Not, Equal, Or, Bool
from trytond.pool import PoolMeta, Pool
-__all__ = ['Sale', 'SaleLine']
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
@@ -39,18 +37,18 @@
self.price_list = config.sale_price_list
-class SaleLine(metaclass=PoolMeta):
+class Line(metaclass=PoolMeta):
__name__ = 'sale.line'
@classmethod
def __setup__(cls):
- super(SaleLine, cls).__setup__()
+ super().__setup__()
cls.product.context['price_list'] = Eval(
'_parent_sale', {}).get('price_list')
@fields.depends('sale', '_parent_sale.price_list', '_parent_sale.company')
def _get_context_sale_price(self):
- context = super(SaleLine, self)._get_context_sale_price()
+ context = super()._get_context_sale_price()
if self.sale:
if getattr(self.sale, 'price_list', None):
context['price_list'] = self.sale.price_list.id
diff -r d5bd02d543d5 -r c825a39dd9c6 setup.py
--- a/setup.py Sun Feb 23 13:55:00 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton sale price list',
package_dir={'trytond.modules.sale_price_list': '.'},
packages=(
- ['trytond.modules.sale_price_list'] +
- ['trytond.modules.sale_price_list.%s' % p for p in find_packages()]
+ ['trytond.modules.sale_price_list']
+ + ['trytond.modules.sale_price_list.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.sale_price_list': (info.get('xml', [])
@@ -92,7 +92,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r d5bd02d543d5 -r c825a39dd9c6 tests/__init__.py
--- a/tests/__init__.py Sun Feb 23 13:55:00 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.sale_price_list.tests.test_sale_price_list import
suite
+ from trytond.modules.sale_price_list.tests.test_sale_price_list import
suite # noqa: E501
except ImportError:
from .test_sale_price_list import suite
