changeset 83f07b4016d7 in modules/sale_credit_limit:default
details:
https://hg.tryton.org/modules/sale_credit_limit?cmd=changeset;node=83f07b4016d7
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
party.py | 2 --
sale.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 7 insertions(+), 8 deletions(-)
diffs (66 lines):
diff -r 782aaa7c9368 -r 83f07b4016d7 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 782aaa7c9368 -r 83f07b4016d7 party.py
--- a/party.py Wed Dec 04 11:09:36 2019 +0100
+++ b/party.py Sun Mar 01 12:33:53 2020 +0100
@@ -5,8 +5,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.transaction import Transaction
-__all__ = ['Party']
-
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
diff -r 782aaa7c9368 -r 83f07b4016d7 sale.py
--- a/sale.py Wed Dec 04 11:09:36 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -3,8 +3,6 @@
from trytond.model import ModelView, Workflow
from trytond.pool import PoolMeta
-__all__ = ['Sale']
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
diff -r 782aaa7c9368 -r 83f07b4016d7 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton sale credit limit',
package_dir={'trytond.modules.sale_credit_limit': '.'},
packages=(
- ['trytond.modules.sale_credit_limit'] +
- ['trytond.modules.sale_credit_limit.%s' % p for p in find_packages()]
+ ['trytond.modules.sale_credit_limit']
+ + ['trytond.modules.sale_credit_limit.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.sale_credit_limit': (info.get('xml', [])
@@ -92,7 +92,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 782aaa7c9368 -r 83f07b4016d7 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.sale_credit_limit.tests.test_sale_credit_limit import
suite
+ from trytond.modules.sale_credit_limit.tests.test_sale_credit_limit import
suite # noqa: E501
except ImportError:
from .test_sale_credit_limit import suite
