changeset fbc8e582d842 in modules/stock_package_shipping:default
details:
https://hg.tryton.org/modules/stock_package_shipping?cmd=changeset;node=fbc8e582d842
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 14 +++++++-------
carrier.py | 2 --
setup.py | 7 ++++---
stock.py | 2 --
5 files changed, 13 insertions(+), 14 deletions(-)
diffs (82 lines):
diff -r 9fdd5cf7302b -r fbc8e582d842 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 9fdd5cf7302b -r fbc8e582d842 __init__.py
--- a/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -3,17 +3,17 @@
from trytond.pool import Pool
-from .stock import *
-from .carrier import *
+from . import stock
+from . import carrier
def register():
Pool.register(
- PackageType,
- Package,
- ShipmentOut,
- Carrier,
+ stock.PackageType,
+ stock.Package,
+ stock.ShipmentOut,
+ carrier.Carrier,
module='stock_package_shipping', type_='model')
Pool.register(
- CreateShipping,
+ stock.CreateShipping,
module='stock_package_shipping', type_='wizard')
diff -r 9fdd5cf7302b -r fbc8e582d842 carrier.py
--- a/carrier.py Wed Dec 04 11:09:37 2019 +0100
+++ b/carrier.py Sun Mar 01 12:33:54 2020 +0100
@@ -4,8 +4,6 @@
from trytond.model import fields
from trytond.pool import PoolMeta
-__all__ = ['Carrier']
-
class Carrier(metaclass=PoolMeta):
__name__ = 'carrier'
diff -r 9fdd5cf7302b -r fbc8e582d842 setup.py
--- a/setup.py Wed Dec 04 11:09:37 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton stock package shipping',
package_dir={'trytond.modules.stock_package_shipping': '.'},
packages=(
- ['trytond.modules.stock_package_shipping'] +
- ['trytond.modules.stock_package_shipping.%s' % p
+ ['trytond.modules.stock_package_shipping']
+ + ['trytond.modules.stock_package_shipping.%s' % p
for p in find_packages()]
),
package_data={
@@ -96,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Czech',
diff -r 9fdd5cf7302b -r fbc8e582d842 stock.py
--- a/stock.py Wed Dec 04 11:09:37 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:54 2020 +0100
@@ -11,8 +11,6 @@
from .exceptions import PackWarning
-__all__ = ['PackageType', 'Package', 'ShipmentOut', 'CreateShipping']
-
class PackageType(metaclass=PoolMeta):
__name__ = 'stock.package.type'
