changeset b330c53201be in modules/stock_lot_unit:default
details:
https://hg.tryton.org/modules/stock_lot_unit?cmd=changeset;node=b330c53201be
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
product.py | 3 ---
setup.py | 7 ++++---
stock.py | 7 -------
4 files changed, 6 insertions(+), 13 deletions(-)
diffs (60 lines):
diff -r 402c62db0a9a -r b330c53201be .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 402c62db0a9a -r b330c53201be product.py
--- a/product.py Wed Dec 04 11:09:37 2019 +0100
+++ b/product.py Sun Mar 01 12:33:54 2020 +0100
@@ -6,9 +6,6 @@
from trytond.pyson import Eval
-__all__ = ['Template', 'Product']
-
-
class Template(metaclass=PoolMeta):
__name__ = 'product.template'
diff -r 402c62db0a9a -r b330c53201be setup.py
--- a/setup.py Wed Dec 04 11:09:37 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton stock lot unit serial',
package_dir={'trytond.modules.stock_lot_unit': '.'},
packages=(
- ['trytond.modules.stock_lot_unit'] +
- ['trytond.modules.stock_lot_unit.%s' % p for p in find_packages()]
+ ['trytond.modules.stock_lot_unit']
+ + ['trytond.modules.stock_lot_unit.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.stock_lot_unit': (info.get('xml', [])
@@ -94,7 +94,8 @@
'Framework :: Tryton',
'Intended Audience :: Developers',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 402c62db0a9a -r b330c53201be stock.py
--- a/stock.py Wed Dec 04 11:09:37 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:54 2020 +0100
@@ -9,13 +9,6 @@
from .exceptions import LotUnitQuantityError
-__all__ = [
- 'Lot', 'Move', 'Inventory', 'InventoryCount',
- 'ShipmentIn', 'ShipmentInReturn',
- 'ShipmentOut', 'ShipmentOutReturn',
- 'Production',
- ]
-
class Lot(metaclass=PoolMeta):
__name__ = 'stock.lot'
