changeset 1228061b1636 in modules/stock_supply_forecast:default
details:
https://hg.tryton.org/modules/stock_supply_forecast?cmd=changeset;node=1228061b1636
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 4 ++--
purchase_request.py | 6 ++----
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 11 insertions(+), 10 deletions(-)
diffs (80 lines):
diff -r b91f8fc900bc -r 1228061b1636 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r b91f8fc900bc -r 1228061b1636 __init__.py
--- a/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,10 +2,10 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .purchase_request import *
+from . import purchase_request
def register():
Pool.register(
- PurchaseRequest,
+ purchase_request.Request,
module='stock_supply_forecast', type_='model')
diff -r b91f8fc900bc -r 1228061b1636 purchase_request.py
--- a/purchase_request.py Wed Dec 04 11:09:37 2019 +0100
+++ b/purchase_request.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,10 +2,8 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool, PoolMeta
-__all__ = ['PurchaseRequest']
-
-class PurchaseRequest(metaclass=PoolMeta):
+class Request(metaclass=PoolMeta):
__name__ = 'purchase.request'
@classmethod
@@ -21,5 +19,5 @@
('state', '=', 'done'),
])
Forecast.create_moves(forecasts)
- super(PurchaseRequest, cls).generate_requests(*args, **kwargs)
+ super().generate_requests(*args, **kwargs)
Forecast.delete_moves(forecasts)
diff -r b91f8fc900bc -r 1228061b1636 setup.py
--- a/setup.py Wed Dec 04 11:09:37 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton stock supply forecast',
package_dir={'trytond.modules.stock_supply_forecast': '.'},
packages=(
- ['trytond.modules.stock_supply_forecast'] +
- ['trytond.modules.stock_supply_forecast.%s' % p
+ ['trytond.modules.stock_supply_forecast']
+ + ['trytond.modules.stock_supply_forecast.%s' % p
for p in find_packages()]
),
package_data={
@@ -95,7 +95,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r b91f8fc900bc -r 1228061b1636 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.stock_supply_forecast.tests.test_stock_supply_forecast import
suite
+ from
trytond.modules.stock_supply_forecast.tests.test_stock_supply_forecast import
suite # noqa: E501
except ImportError:
from .test_stock_supply_forecast import suite
