changeset 7b3f7940e994 in modules/stock_package_shipping_dpd:default
details:
https://hg.tryton.org/modules/stock_package_shipping_dpd?cmd=changeset;node=7b3f7940e994
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 14 +++++++-------
carrier.py | 2 --
setup.py | 7 ++++---
stock.py | 2 --
tests/__init__.py | 2 +-
6 files changed, 14 insertions(+), 15 deletions(-)
diffs (94 lines):
diff -r e8bb69222274 -r 7b3f7940e994 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r e8bb69222274 -r 7b3f7940e994 __init__.py
--- a/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -3,17 +3,17 @@
from trytond.pool import Pool
-from .carrier import *
-from .stock import *
+from . import carrier
+from . import stock
def register():
Pool.register(
- CredentialDPD,
- Carrier,
- ShipmentOut,
+ carrier.CredentialDPD,
+ carrier.Carrier,
+ stock.ShipmentOut,
module='stock_package_shipping_dpd', type_='model')
Pool.register(
- CreateShipping,
- CreateDPDShipping,
+ stock.CreateShipping,
+ stock.CreateDPDShipping,
module='stock_package_shipping_dpd', type_='wizard')
diff -r e8bb69222274 -r 7b3f7940e994 carrier.py
--- a/carrier.py Wed Dec 04 11:09:37 2019 +0100
+++ b/carrier.py Sun Mar 01 12:33:54 2020 +0100
@@ -12,8 +12,6 @@
from .configuration import get_client, LOGIN_SERVICE
from .exceptions import DPDError
-__all__ = ['CredentialDPD', 'Carrier']
-
class CredentialDPD(ModelSQL, ModelView, MatchMixin):
'DPD Credential'
diff -r e8bb69222274 -r 7b3f7940e994 setup.py
--- a/setup.py Wed Dec 04 11:09:37 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton stock package shipping dpd',
package_dir={'trytond.modules.stock_package_shipping_dpd': '.'},
packages=(
- ['trytond.modules.stock_package_shipping_dpd'] +
- ['trytond.modules.stock_package_shipping_dpd.%s' % p
+ ['trytond.modules.stock_package_shipping_dpd']
+ + ['trytond.modules.stock_package_shipping_dpd.%s' % p
for p in find_packages()]
),
package_data={
@@ -96,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Czech',
diff -r e8bb69222274 -r 7b3f7940e994 stock.py
--- a/stock.py Wed Dec 04 11:09:37 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:54 2020 +0100
@@ -20,8 +20,6 @@
from .configuration import get_client, SHIPMENT_SERVICE
from .exceptions import DPDError
-__all__ = ['ShipmentOut', 'CreateShipping', 'CreateDPDShipping']
-
class ShipmentOut(metaclass=PoolMeta):
__name__ = 'stock.shipment.out'
diff -r e8bb69222274 -r 7b3f7940e994 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.stock_package_shipping_dpd.tests.test_stock_package_shipping_dpd
import suite
+ from
trytond.modules.stock_package_shipping_dpd.tests.test_stock_package_shipping_dpd
import suite # noqa: E501
except ImportError:
from .test_stock_package_shipping_dpd import suite
