[tryton-commits] changeset in modules/account:5.6 Use getattr instead of testing ...

[Cédric Krier]

changeset f438a1981037 in modules/account:5.6
details: https://hg.tryton.org/modules/account?cmd=changeset;node=f438a1981037
description:
        Use getattr instead of testing origin id

        Since changeset b8d76b07910f, the reference value of a negative id is a 
string
        so testing the id does not work. It is safer to call getattr with a 
default
        empty string value.

        issue9500
        review304611002
        (grafted from 64b7fe63694035a593bfb467408f9d1106d065f3)
diffstat:

 general_ledger.fodt |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r af1ffed741d6 -r f438a1981037 general_ledger.fodt
--- a/general_ledger.fodt       Sun Oct 18 20:49:47 2020 +0200
+++ b/general_ledger.fodt       Sun Oct 25 11:02:23 2020 +0100
@@ -894,7 +894,7 @@
       <text:p text:style-name="P10"><text:placeholder 
text:placeholder-type="text">&lt;line.description or 
&apos;&apos;&gt;</text:placeholder><text:line-break/><text:placeholder 
text:placeholder-type="text">&lt;line.move_description or 
&apos;&apos;&gt;</text:placeholder></text:p>
      </table:table-cell>
      <table:table-cell table:style-name="Table3.G11" 
office:value-type="string">
-      <text:p text:style-name="P10"><text:placeholder 
text:placeholder-type="text">&lt;line.origin.rec_name if line.origin and 
line.origin.id &gt;= 0 else &apos;&apos;&gt;</text:placeholder></text:p>
+      <text:p text:style-name="P10"><text:placeholder 
text:placeholder-type="text">&lt;getattr(line.origin, &apos;rec_name&apos;, 
&apos;&apos;)&gt;</text:placeholder></text:p>
      </table:table-cell>
      <table:table-cell table:style-name="Table3.H11" 
office:value-type="string">
       <text:p text:style-name="P10"><text:placeholder 
text:placeholder-type="text">&lt;line.state_string&gt;</text:placeholder></text:p>