[tryton-commits] changeset in modules/sale_opportunity:default Replace cursor fet...

[Cédric Krier]

changeset 4cbadd5f1466 in modules/sale_opportunity:default
details: 
https://hg.tryton.org/modules/sale_opportunity?cmd=changeset&node=4cbadd5f1466
description:
        Replace cursor fetchall by iteration over cursor

        issue5817
        review335831003
diffstat:

 opportunity.py |  8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diffs (25 lines):

diff -r eecd10f62570 -r 4cbadd5f1466 opportunity.py
--- a/opportunity.py    Thu Mar 18 23:04:17 2021 +0100
+++ b/opportunity.py    Sun Mar 21 16:09:13 2021 +0100
@@ -134,7 +134,9 @@
     def __register__(cls, module_name):
         pool = Pool()
         Sale = pool.get('sale.sale')
-        cursor = Transaction().connection.cursor()
+        transaction = Transaction()
+        cursor = transaction.connection.cursor()
+        update = transaction.connection.cursor()
         sql_table = cls.__table__()
         sale = Sale.__table__()
 
@@ -154,8 +156,8 @@
             cursor.execute(*sql_table.select(
                     sql_table.id, sql_table.sale,
                     where=sql_table.sale != Null))
-            for id_, sale_id in cursor.fetchall():
-                cursor.execute(*sale.update(
+            for id_, sale_id in cursor:
+                update.execute(*sale.update(
                         columns=[sale.origin],
                         values=['%s,%s' % (cls.__name__, id_)],
                         where=sale.id == sale_id))