changeset 692c1477bcd5 in modules/stock_assign_manual:5.8 details: https://hg.tryton.org/modules/stock_assign_manual?cmd=changeset&node=692c1477bcd5 description: Restore initial values if assign_try is partial
The assign_try method may have saved the move with the modification applied by the key. So we must restore the initial values for the unassigned quantity. issue10729 review379081002 (grafted from babb936c3f84b93ead038a1e587d988b22a20ccd) diffstat: stock.py | 22 ++++++++++++++++------ 1 files changed, 16 insertions(+), 6 deletions(-) diffs (38 lines): diff -r a43f559bd67f -r 692c1477bcd5 stock.py --- a/stock.py Fri Jan 01 16:39:31 2021 +0100 +++ b/stock.py Sun Oct 03 00:29:16 2021 +0200 @@ -262,18 +262,28 @@ self.move.save() Move.copy([self.move], {'quantity': remainder}) key = json.loads(self.place) - self._apply(key, grouping) + values = self._apply(key, grouping) quantity = self.move.quantity Move.assign_try([self.move], with_childs=False, grouping=grouping) - if self.move.state != 'assigned' and self.move.quantity == quantity: - raise UserError(gettext( - 'stock_assign_manual.msg_assign_failed', - move=self.move.rec_name, - place=self.place_string)) + if self.move.state != 'assigned': + # Restore initial values as assign_try may have saved the move + for field, value in values.items(): + setattr(self.move, field, value) + self.move.save() + if self.move.quantity == quantity: + raise UserError(gettext( + 'stock_assign_manual.msg_assign_failed', + move=self.move.rec_name, + place=self.place_string)) def _apply(self, key, grouping): + """Update the move according to the key + and return a dictionary with the initial values.""" + values = {'from_location': self.move.from_location.id} location_id = key[0] self.move.from_location = location_id for field, value in zip(grouping, key[1:]): if value is not None and '.' not in field: + values[field] = getattr(self.move, field) setattr(self.move, field, value) + return values