details: https://code.tryton.org/tryton/commit/9e144f69fbac
branch: 7.0
user: Cédric Krier <[email protected]>
date: Mon Nov 17 12:26:57 2025 +0100
description:
Enforce access check in export_data
As the method is using instances to construct the exported data, the
access
must be checked explicitly.
Closes #14366
(grafted from 4e3e875a295e533244d0f28c1cf2efe5187489ba)
diffstat:
trytond/CHANGELOG | 1 +
trytond/trytond/model/modelstorage.py | 23 +++++++++++++++++++++++
2 files changed, 24 insertions(+), 0 deletions(-)
diffs (48 lines):
diff -r b0035b3abddc -r 9e144f69fbac trytond/CHANGELOG
--- a/trytond/CHANGELOG Wed Nov 12 14:56:34 2025 +0100
+++ b/trytond/CHANGELOG Mon Nov 17 12:26:57 2025 +0100
@@ -1,3 +1,4 @@
+* Enforce access check in export_data (issue14366)
* Include the traceback only in RPC responses in development mode (issue14354)
* Enforce access check in HTML editor route (issue14364)
diff -r b0035b3abddc -r 9e144f69fbac trytond/trytond/model/modelstorage.py
--- a/trytond/trytond/model/modelstorage.py Wed Nov 12 14:56:34 2025 +0100
+++ b/trytond/trytond/model/modelstorage.py Mon Nov 17 12:26:57 2025 +0100
@@ -700,6 +700,11 @@
@staticmethod
def __export_row(record, fields_names):
pool = Pool()
+ ModelAccess = pool.get('ir.model.access')
+ ModelFieldAccess = pool.get('ir.model.field.access')
+ Rule = pool.get('ir.rule')
+ IrModel = pool.get('ir.model')
+
lines = []
data = ['' for x in range(len(fields_names))]
done = []
@@ -718,6 +723,24 @@
field_name, descriptor = field_name.split('.')
eModel = pool.get(value.__name__)
field = eModel._fields[field_name]
+
+ ModelAccess.check(eModel.__name__, 'read')
+ ModelFieldAccess.check(eModel.__name__, [field_name], 'read')
+ domain = Rule.domain_get(eModel.__name__, mode='read')
+ if (domain
+ and not eval_domain(
+ domain, EvalEnvironment(value, eModel))):
+ clause, clause_global = Rule.get(
+ eModel.__name__, mode='read')
+ rules = []
+ rules.extend(clause.keys())
+ rules.extend(clause_global.keys())
+ raise AccessError(gettext(
+ 'ir.msg_read_rule_error',
+ ids=str(value.id),
+ model=IrModel.get_name(eModel.__name__),
+ rules='\n'.join(r.name for r in rules)))
+
if field.states and 'invisible' in field.states:
invisible = _record_eval_pyson(
value, field.states['invisible'])