details:   https://code.tryton.org/tryton/commit/9a5fc16b48b6
branch:    8.0
user:      Cédric Krier <[email protected]>
date:      Wed Jul 29 19:30:48 2026 +0200
description:
        Do not set a shipment cost method for Shopify order without shipping 
line

        Without a shipping line, there is no carrier selected and thus no 
shipment cost
        method to set.

        Closes #14976
        (grafted from 313b466eb1c55ac922819a5b66dc49e081e85064)
diffstat:

 modules/web_shop_shopify/sale.py |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (14 lines):

diff -r 0500ed4bcc01 -r 9a5fc16b48b6 modules/web_shop_shopify/sale.py
--- a/modules/web_shop_shopify/sale.py  Tue Jul 28 19:23:07 2026 +0200
+++ b/modules/web_shop_shopify/sale.py  Wed Jul 29 19:30:48 2026 +0200
@@ -836,8 +836,8 @@
             else:
                 if available_carriers:
                     carrier = available_carriers[0]
-                else:
-                    shipment_cost_method = None
+        if not carrier:
+            shipment_cost_method = None
         setattr_changed(self, 'carrier', carrier)
         setattr_changed(self, 'shipment_cost_method', shipment_cost_method)
 

Reply via email to