[tryton-commits] [tryton] [default] Test findtext result as boolean when parsing ...

[Cédric Krier]

details:   https://code.tryton.org/tryton/commit/ebb739d27852
branch:    default
user:      Cédric Krier <c...@b2ck.com>
date:      Tue Aug 11 12:02:09 2026 +0200
description:
        Test findtext result as boolean when parsing UBL invoice

        Closes #15003
diffstat:

 modules/edocument_ubl/edocument.py |  8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diffs (25 lines):

diff -r f730392a2701 -r ebb739d27852 modules/edocument_ubl/edocument.py
--- a/modules/edocument_ubl/edocument.py        Mon Aug 17 15:06:09 2026 +0200
+++ b/modules/edocument_ubl/edocument.py        Tue Aug 11 12:02:09 2026 +0200
@@ -1080,9 +1080,8 @@
         address.building_number = address_el.findtext('./{*}BuildingNumber')
         address.city = address_el.findtext('./{*}CityName')
         address.postal_code = address_el.findtext('./{*}PostalZone')
-        if (country_code := address_el.findtext(
-                    './{*}Country/{*}IdentificationCode[@listId="ISO3166-1"]')
-                ) is not None:
+        if country_code := address_el.findtext(
+                './{*}Country/{*}IdentificationCode[@listId="ISO3166-1"]'):
             try:
                 country, = Country.search([
                         ('code', '=', country_code),
@@ -1221,8 +1220,7 @@
                     pass
                 else:
                     return product
-        if (code := item.findtext('./{*}BuyersItemIdentification/{*}ID')
-                ) is not None:
+        if code := item.findtext('./{*}BuyersItemIdentification/{*}ID'):
             try:
                 product, = Product.search([
                         ('code', '=', code),