details:   https://code.tryton.org/tryton/commit/96de70420cfe
branch:    default
user:      Cédric Krier <[email protected]>
date:      Fri Nov 13 14:47:31 2026 +0100
description:
        Do not create contact mechanism for invalid phone from Shopify

        Closes #15238
diffstat:

 modules/web_shop_shopify/party.py |  16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diffs (33 lines):

diff -r 5e13f6c2e321 -r 96de70420cfe modules/web_shop_shopify/party.py
--- a/modules/web_shop_shopify/party.py Mon Nov 16 13:00:38 2026 +0100
+++ b/modules/web_shop_shopify/party.py Fri Nov 13 14:47:31 2026 +0100
@@ -2,6 +2,12 @@
 # this repository contains the full copyright notices and license terms.
 import logging
 
+try:
+    import phonenumbers
+    from phonenumbers import NumberParseException
+except ImportError:
+    phonenumbers = None
+
 from trytond.model import sequence_reorder
 from trytond.pool import Pool, PoolMeta
 from trytond.tools import remove_forbidden_chars
@@ -68,6 +74,16 @@
                     except EmailNotValidError as e:
                         logger.info("Skip email %s", value, exc_info=e)
                         continue
+                elif types[0] == 'phone':
+                    if phonenumbers:
+                        try:
+                            phonenumber = phonenumbers.parse(value)
+                        except NumberParseException as e:
+                            logger.info("Skip phone %s", value, exc_info=e)
+                            continue
+                        if not phonenumbers.is_valid_number(phonenumber):
+                            logger.info("Skip phone %s", value)
+                            continue
                 contact_mechanisms.insert(index, ContactMechanism(
                         type=types[0], value=value))
         party.contact_mechanisms = sequence_reorder(contact_mechanisms)

Reply via email to