wweic commented on a change in pull request #4643: [REFACTOR] Replace TensorObj
and TensorValue with NDArray
URL: https://github.com/apache/incubator-tvm/pull/4643#discussion_r364077430
##########
File path: include/tvm/relay/interpreter.h
##########
@@ -143,89 +121,66 @@ class RecClosureNode : public ValueNode {
TVM_DLL static RecClosure make(Closure clos, Var bind);
static constexpr const char* _type_key = "relay.RecClosure";
- TVM_DECLARE_FINAL_OBJECT_INFO(RecClosureNode, ValueNode);
+ TVM_DECLARE_FINAL_OBJECT_INFO(RecClosureNode, Object);
};
-class RecClosure : public Value {
+class RecClosure : public ObjectRef {
public:
- TVM_DEFINE_OBJECT_REF_METHODS(RecClosure, Value, RecClosureNode);
+ TVM_DEFINE_OBJECT_REF_METHODS(RecClosure, ObjectRef, RecClosureNode);
};
/*! \brief A tuple value. */
class TupleValue;
/*! \brief Tuple (x, ... y). */
-struct TupleValueNode : ValueNode {
- tvm::Array<Value> fields;
+struct TupleValueNode : Object {
Review comment:
```suggestion
struct TupleValueObj : Object {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
