trevor-m opened a new pull request #4668: Fix Base64OutStream portability issue URL: https://github.com/apache/incubator-tvm/pull/4668 Fixes #4660 On ARM, char is unsigned by default while on x86 it is signed by default. On ARM, this causes the logic in `Base64OutStream::Finish` to incorrectly add a char with value of 255 to the end of every b64 string. Fix is to use int for the endchar. Alternatively we could explicitly use `signed char`. https://www.linuxtopia.org/online_books/an_introduction_to_gcc/gccintro_71.html
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
