ZihengJiang commented on a change in pull request #4698: [Runtime] EdgeTPU runtime for Coral Boards URL: https://github.com/apache/incubator-tvm/pull/4698#discussion_r366016186
########## File path: python/tvm/contrib/tflite_runtime.py ########## @@ -18,7 +18,7 @@ from .._ffi.function import get_global_func from ..rpc import base as rpc_base -def create(tflite_model_bytes, ctx): +def create(tflite_model_bytes, ctx, target_edgetpu=False): Review comment: instead of a boolean argument, try to use a target string for future expansion: `target='edge_tpu'/'cpu'` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services