shoubhik commented on a change in pull request #4714: Mxnet parser for Qnn
dialect
URL: https://github.com/apache/incubator-tvm/pull/4714#discussion_r367724657
##########
File path: python/tvm/relay/frontend/mxnet.py
##########
@@ -180,6 +190,17 @@ def _mx_conv2d(inputs, attrs):
new_attrs["groups"] = attrs.get_int("num_group", 1)
new_attrs["data_layout"] = data_layout
new_attrs["kernel_layout"] = kernel_layout
+ return new_attrs
+
+def _mx_conv2d(inputs, attrs):
+ kernel_size = attrs.get_int_tuple("kernel")
+ data_layout = attrs.get_str("layout", "NCHW")
+ if len(kernel_size) != 2:
+ raise tvm.error.OpAttributeInvalid(
+ 'Non 1D or 2D kernels are not supported for operator Convolution')
Review comment:
This condition seems to be from an older version of mxnet. It makes more
sense to put this change in a separate PR after more extensive testing.
Latest mxnet
https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/convolution.cc#L364-L368
does support 1,2,3 dic kernels
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
