FrozenGene commented on a change in pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r373309999
########## File path: topi/include/topi/elemwise.h ########## @@ -360,5 +359,71 @@ inline Tensor full_like(const Tensor& x, }, name, tag); } + /* + * \brief Fast exponential function implementation from Eigen + * https://github.com/eigenteam/eigen-git-mirror/blob/master/Eigen/src/Core/arch/Default/GenericPacketMathFunctions.h#L183 Review comment: does MPL2 allow somebody modify the code and doesn't open source? This is critical for company using TVM. I worried about it. However, I am not the expert of open source license. Maybe @tqchen could have more authoritative answer about it. My previous meaning is if you understand it and write it by yourself, you could remove this link so that we could avoid license problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
