tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800566
########## File path: include/tvm/runtime/container.h ########## @@ -24,11 +24,35 @@ #ifndef TVM_RUNTIME_CONTAINER_H_ #define TVM_RUNTIME_CONTAINER_H_ +// Reference for feature test macros of string_view: +// https://isocpp.org/std/standing-documents/sd-6-sg10-feature-test-recommendations Review comment: Let us comment about the rationale here about why do we include std::experimental::string_view in c++14. And comment that the usage is only limited to hash ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
