inadob commented on a change in pull request #4915: [Frontend][TFLite] Add
parser support for 'square' operator
URL: https://github.com/apache/incubator-tvm/pull/4915#discussion_r381949778
##########
File path: tests/python/frontend/tflite/test_forward.py
##########
@@ -742,26 +742,35 @@ def _test_neg(data):
""" One iteration of neg """
return _test_unary_elemwise(math_ops.neg, data)
#######################################################################
+# Square
+# ------
+
+def _test_square(data):
+ """ One iteration of square """
+ return _test_unary_elemwise(math_ops.square, data)
+#######################################################################
Review comment:
> You could also refer to the implementation in
`convert_squared_difference`, maybe could consider using `power`.
I implemented it with `multiply` since we already know how to do this in
case the input is quantized. Later I saw that uint8 is still not supported...
In general, I don't think multiply/power makes a lot of difference to the
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
