[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4923: [LLVM] Fix build breaks with StringRef changes

[GitBox]

FrozenGene commented on a change in pull request #4923: [LLVM] Fix build breaks 
with StringRef changes
URL: https://github.com/apache/incubator-tvm/pull/4923#discussion_r383061942
 
 

 ##########
 File path: src/target/llvm/llvm_module.cc
 ##########
 @@ -239,7 +239,7 @@ class LLVMModuleNode final : public runtime::ModuleNode {
     if (mtarget != nullptr) {
       llvm::MDString* pstr = llvm::dyn_cast<llvm::MDString>(mtarget);
       CHECK(pstr != nullptr);
-      target_ = pstr->getString();
+      target_ = pstr->getString().str();
 
 Review comment:
   std::string(ptr->getString()) should work well on all llvm versions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services