zhiics commented on a change in pull request #4934: [Relay][External Codegen]
Support data types for CSourceModuleCodegen args and output
URL: https://github.com/apache/incubator-tvm/pull/4934#discussion_r383542966
##########
File path: src/relay/backend/contrib/codegen_c/codegen_c.h
##########
@@ -207,17 +215,20 @@ class CodegenCBase {
*
* \return The emitted code string.
*/
- std::string JitImpl(std::string ext_func_id, std::vector<std::string> args,
+ std::string JitImpl(std::string ext_func_id, Array<Var> args,
Review comment:
please also use const reference here for all parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
