kevinthesun commented on a change in pull request #4930: [Frontend] [MXNet]
make_loss operator support
URL: https://github.com/apache/incubator-tvm/pull/4930#discussion_r384037726
##########
File path: python/tvm/relay/frontend/mxnet.py
##########
@@ -646,6 +646,11 @@ def _mx_arange(inputs, attrs):
return _op.arange(**new_attrs)
+# pylint: disable=unused-argument
+def _mx_make_loss(inputs, attrs):
Review comment:
In this case, I suggest we add a comment saying something like "In inference
mode make_loss is just identity and has no actual effect."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
